entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 31 Releases Activity

misc: do not allow single quotes in custom identifiers (#89816) #1427

Merged
fpeters merged 1 commits from wip/89816-custom-id-quote into main 2024-04-22 10:01:56 +02:00
Conversation 0 Commits 1 Files Changed 2 +2 -2
fpeters commented 2024-04-19 17:10:12 +02:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-04-19 17:10:12 +02:00
fpeters reviewed 2024-04-19 17:10:56 +02:00
wcs/formdata.py
@ -502,4 +502,3 @@
@classmethod
def force_valid_id_characters(cls, value):
value = unidecode.unidecode(value)
value = re.sub(r'[^\w\s\'\-_]', '', unidecode.unidecode(value)).strip()
fpeters commented 2024-04-19 17:10:39 +02:00
Author
Owner
Copy Link

Il y avait deux fois l'appel à unidecode.unidecode, inutile, je nettoie.

Il y avait deux fois l'appel à unidecode.unidecode, inutile, je nettoie.
wcs/formdata.py
@ -504,3 +504,2 @@
value = unidecode.unidecode(value)
value = re.sub(r'[^\w\s\'\-_]', '', unidecode.unidecode(value)).strip()
value = re.sub(r'\s+', '-', value)
value = re.sub(r'[\s\']+', '-', value)
fpeters commented 2024-04-19 17:10:52 +02:00
Author
Owner
Copy Link

Remplacement des apostrophes par des tirets.

Remplacement des apostrophes par des tirets.
fpeters changed title from WIP: misc: do not allow single quotes in custom identifiers (#89816) to misc: do not allow single quotes in custom identifiers (#89816) 2024-04-19 17:18:30 +02:00
lguerin approved these changes 2024-04-22 09:34:25 +02:00
fpeters merged commit b6c83cca37 into main 2024-04-22 10:01:56 +02:00
fpeters deleted branch wip/89816-custom-id-quote 2024-04-22 10:01:56 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1427
No description provided.
Delete Branch "wip/89816-custom-id-quote"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?