misc: do not allow single quotes in custom identifiers (#89816)
gitea/wcs/pipeline/head This commit looks good Details

This commit is contained in:
Frédéric Péters 2024-04-19 17:09:48 +02:00
parent 0dc5d3267f
commit 7e92bacef5
2 changed files with 2 additions and 2 deletions

View File

@ -1331,6 +1331,7 @@ def test_card_custom_id_format(pub):
assert data_class.force_valid_id_characters('_Fôô bar-') == '_Foo-bar-'
assert data_class.force_valid_id_characters('_Fôô bar☭-') == '_Foo-bar-'
assert data_class.force_valid_id_characters('_Fôô bar❗') == '_Foo-bar'
assert data_class.force_valid_id_characters(' Foo\'bar') == 'Foo-bar'
def test_card_update_related(pub):

View File

@ -501,9 +501,8 @@ class FormData(StorableObject):
@classmethod
def force_valid_id_characters(cls, value):
value = unidecode.unidecode(value)
value = re.sub(r'[^\w\s\'\-_]', '', unidecode.unidecode(value)).strip()
value = re.sub(r'\s+', '-', value)
value = re.sub(r'[\s\']+', '-', value)
return value
def set_auto_fields(self, *args, **kwargs):