entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 35 Releases Activity

misc: complete and allow translation of leaflet title attribute (#88610) #1310

Merged
fpeters merged 2 commits from wip/88610-a11y-leaflet-title-attribute into main 2024-03-29 08:33:19 +01:00
Conversation 0 Commits 2 Files Changed 2 +5 -1
fpeters commented 2024-03-25 11:45:43 +01:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-03-25 11:45:43 +01:00
fpeters force-pushed wip/88610-a11y-leaflet-title-attribute from c7c0c9a380 to 0f494dc500 2024-03-25 11:59:15 +01:00 Compare
fpeters reviewed 2024-03-25 12:08:16 +01:00
wcs/qommon/static/js/qommon.map.js
@ -27,2 +27,4 @@
map_options.gestureHandling = true;
var map = L.map($(this).attr('id'), map_options);
map.attributionControl.setPrefix(
'<a href="https://leafletjs.com" title="' + WCS_I18N.map_leaflet_title_attribute + '">Leaflet</a>')
fpeters commented 2024-03-25 12:07:24 +01:00
Author
Owner
Copy Link

J'avais d'abord uniquement vu ici une chaine en anglais.

J'avais d'abord uniquement vu ici une chaine en anglais.
wcs/qommon/static/js/qommon.map.js
@ -205,3 +207,3 @@
$map_widget.on('set-geolocation', function(e, coords, options) {
if (map.marker === null) {
map.marker = L.marker([0, 0]);
map.marker = L.marker([0, 0], {alt: WCS_I18N.map_position_marker_alt});
fpeters commented 2024-03-25 12:07:46 +01:00
Author
Owner
Copy Link

Mais pour le marqueur aussi, par défaut il a alt="Marker", pas traduit.

Mais pour le marqueur aussi, par défaut il a alt="Marker", pas traduit.
wcs/views.py
@ -74,12 +74,14 @@ def i18n_js(request):
'geoloc_permission_denied': _('Geolocation: permission denied'),
'geoloc_position_unavailable': _('Geolocation: position unavailable'),
'geoloc_timeout': _('Geolocation: timeout'),
'map_position_marker_alt': _('Marker of selected position'),
fpeters commented 2024-03-25 12:08:11 +01:00
Author
Owner
Copy Link

Comme juste "Marqueur" ça faisait un peu léger j'ai explicité.

Comme juste "Marqueur" ça faisait un peu léger j'ai explicité.
fpeters changed title from WIP: misc: complete and allow translation of leaflet title attribute (#88610) to misc: complete and allow translation of leaflet title attribute (#88610) 2024-03-25 12:08:20 +01:00
tnoel approved these changes 2024-03-25 12:14:43 +01:00
fpeters merged commit 8985a905ae into main 2024-03-29 08:33:19 +01:00
fpeters deleted branch wip/88610-a11y-leaflet-title-attribute 2024-03-29 08:33:19 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1310
No description provided.
Delete Branch "wip/88610-a11y-leaflet-title-attribute"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?