entrouvert
/
django-mellon
16
0
Fork 0
Code Issues Pull Requests Releases Activity

Do not use a subquery to clean dead sessions (#80626) #7

Merged
bdauvergne merged 1 commits from wip/80626-Eviter-d-utiliser-une-subquery-p into main 2023-08-29 12:14:42 +02:00
Conversation 0 Commits 1 Files Changed 1 +2 -2
bdauvergne commented 2023-08-28 17:59:23 +02:00
Owner
Copy Link
No description provided.
bdauvergne added 1 commit 2023-08-28 17:59:23 +02:00
gitea/django-mellon/pipeline/head This commit looks good Details
6be8fd1994 Do not use a subquery to clean dead sessions (#80626)
ecazenave requested changes 2023-08-28 18:28:01 +02:00
mellon/models.py Outdated
@ -84,3 +84,3 @@
if not store.exists(session_key):
dead_session_keys.append(session_key)
cls.objects.filter(session_key__in=dead_session_keys).delete()
cls.objects.filter(session_key__in=list(dead_session_keys)).delete()
ecazenave commented 2023-08-28 18:27:53 +02:00
Owner
Copy Link

dead_session_keys est déjà une liste.

dead_session_keys est déjà une liste.
bdauvergne commented 2023-08-28 22:25:52 +02:00
Author
Owner
Copy Link

Non ligne 80 ça peut être un set et je n'ai pas voulu réfléchir.

Non ligne 80 ça peut être un set et je n'ai pas voulu réfléchir.
bdauvergne commented 2023-08-28 22:26:12 +02:00
Author
Owner
Copy Link

Je peux remonter le list() ligne 80 si tu préfères.

Je peux remonter le list() ligne 80 si tu préfères.
bdauvergne commented 2023-08-29 10:03:07 +02:00
Author
Owner
Copy Link

C'est fait.

C'est fait.
bdauvergne force-pushed wip/80626-Eviter-d-utiliser-une-subquery-p from 6be8fd1994 to f4ad730ea1 2023-08-29 10:02:45 +02:00 Compare
ecazenave approved these changes 2023-08-29 11:57:33 +02:00
bdauvergne merged commit f4ad730ea1 into main 2023-08-29 12:14:42 +02:00
bdauvergne deleted branch wip/80626-Eviter-d-utiliser-une-subquery-p 2023-08-29 12:14:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
ecazenave
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/django-mellon#7
No description provided.
Delete Branch "wip/80626-Eviter-d-utiliser-une-subquery-p"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?