Do not use a subquery to clean dead sessions (#80626)
gitea/django-mellon/pipeline/head This commit looks good Details

This commit is contained in:
Benjamin Dauvergne 2023-08-28 17:58:14 +02:00
parent 3c4a96ba05
commit f4ad730ea1
1 changed files with 2 additions and 2 deletions

View File

@ -71,13 +71,13 @@ class SessionIndex(models.Model):
)
if chunk_size:
candidates = candidates[:chunk_size]
candidates_session_keys = candidates.values_list('session_key', flat=True)
candidates_session_keys = set(candidates.values_list('session_key', flat=True))
if Session is not None:
# fast path
existing_session_keys = Session.objects.filter(
session_key__in=candidates_session_keys
).values_list('session_key', flat=True)
dead_session_keys = candidates_session_keys.difference(existing_session_keys)
dead_session_keys = list(candidates_session_keys.difference(set(existing_session_keys)))
else:
dead_session_keys = []
for session_key in candidates_session_keys: