entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: do not mark table with required field error before completion (#37449) #969

Merged
fpeters merged 1 commits from wip/37449-table-rows-vs-prefill into main 2024-01-12 15:06:49 +01:00
Conversation 0 Commits 1 Files Changed 3 +71 -9
fpeters commented 2023-12-26 18:49:21 +01:00
Owner
Copy Link
No description provided.
fpeters force-pushed wip/37449-table-rows-vs-prefill from 4b02695b1d to 1eafa518f8 2023-12-26 19:11:14 +01:00 Compare
fpeters force-pushed wip/37449-table-rows-vs-prefill from 1eafa518f8 to 2ea67c268d 2023-12-26 19:39:51 +01:00 Compare
fpeters changed title from WIP: misc: do not mark table with required field error before completion (#37449) to misc: do not mark table with required field error before completion (#37449) 2024-01-05 18:58:57 +01:00
pmarillonnet approved these changes 2024-01-08 08:35:15 +01:00
pmarillonnet left a comment
Owner
Copy Link

Ok. Du détail mais dans test_table_list_rows_required j’aurais bien vu un gestionnaire de contexte plutôt qu’un

try:
    # …
finally:
    # on remet req.environ à la bonne valeur

sans le except qui à première vue pourrait donner l’impression qu’on cherche à ignorer volontairement une exception.

Ok. Du détail mais dans `test_table_list_rows_required` j’aurais bien vu un gestionnaire de contexte plutôt qu’un ```python try: # … finally: # on remet req.environ à la bonne valeur ``` sans le except qui à première vue pourrait donner l’impression qu’on cherche à ignorer volontairement une exception.
fpeters merged commit da95c93575 into main 2024-01-12 15:06:49 +01:00
fpeters deleted branch wip/37449-table-rows-vs-prefill 2024-01-12 15:06:50 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
pmarillonnet
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#969
No description provided.
Delete Branch "wip/37449-table-rows-vs-prefill"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?