entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: add image live preview of file widget (#33301) #927

Merged
tjund merged 1 commits from wip/33301-fileInput-image-preview into main 2024-02-15 16:18:31 +01:00
Conversation 5 Commits 1 Files Changed 2 +11
tjund commented 2023-12-13 17:06:37 +01:00
Owner
Copy Link
No description provided.
tjund added 1 commit 2023-12-13 17:06:37 +01:00
gitea/wcs/pipeline/head This commit looks good Details
dcff57b136 misc: add image live preview of file widget (#33301)
fpeters reviewed 2024-01-16 09:39:21 +01:00
wcs/qommon/static/js/qommon.fileupload.js Outdated
@ -457,0 +470,4 @@
$.WcsFileUpload.img_base64(files_data.files[0], function(image_64) {
base_widget[0].style.setProperty('--image-preview-url', `url(${image_64})`);
});
} */
fpeters commented 2024-01-16 09:39:21 +01:00
Owner
Copy Link

Plutôt supprimer le code.

Plutôt supprimer le code.
tjund commented 2024-01-23 15:22:42 +01:00
Author
Owner
Copy Link

ok, j'ai supprimé la function img_base64 qui n'a alors plus de raison.

ok, j'ai supprimé la function img_base64 qui n'a alors plus de raison.
tjund added 2 commits 2024-01-23 15:17:43 +01:00
gitea/wcs/pipeline/head There was a failure building this commit Details
188eaf40bc correct preview url on css var
tjund commented 2024-01-29 09:35:06 +01:00
Author
Owner
Copy Link

Je n'ai pas compris le rapport entre le test qui ne passe pas et mon code.

Je n'ai pas compris le rapport entre le test qui ne passe pas et mon code.
fpeters commented 2024-01-29 09:42:54 +01:00
Owner
Copy Link

Je n'ai pas compris le rapport entre le test qui ne passe pas et mon code.

Il faut rebaser ta branche.

> Je n'ai pas compris le rapport entre le test qui ne passe pas et mon code. Il faut rebaser ta branche.
tjund force-pushed wip/33301-fileInput-image-preview from 188eaf40bc to 352e9e81af 2024-01-30 16:35:21 +01:00 Compare
tjund commented 2024-01-30 16:41:38 +01:00
Author
Owner
Copy Link

Merci Fred, rebasage ok.

Merci Fred, rebasage ok.
tjund changed title from WIP: misc: add image live preview of file widget (#33301) to misc: add image live preview of file widget (#33301) 2024-01-30 16:45:20 +01:00
csechet approved these changes 2024-02-14 10:39:08 +01:00
fpeters commented 2024-02-14 17:48:52 +01:00
Owner
Copy Link

(attention à valider/assurer la compatibilité avec l'intégration graphique toodego)

(attention à valider/assurer la compatibilité avec l'intégration graphique toodego)
tjund commented 2024-02-15 12:02:53 +01:00
Author
Owner
Copy Link

(attention à valider/assurer la compatibilité avec l'intégration graphique toodego)

J'ai ajouté un commit à la PR PBT : entrouvert/publik-base-theme#462/

> (attention à valider/assurer la compatibilité avec l'intégration graphique toodego) J'ai ajouté un commit à la PR PBT : https://git.entrouvert.org/entrouvert/publik-base-theme/pulls/462/
tjund force-pushed wip/33301-fileInput-image-preview from 352e9e81af to ef7fbfaa8d 2024-02-15 16:05:54 +01:00 Compare
tjund merged commit ef7fbfaa8d into main 2024-02-15 16:18:31 +01:00
tjund deleted branch wip/33301-fileInput-image-preview 2024-02-15 16:18:32 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
csechet
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#927
No description provided.
Delete Branch "wip/33301-fileInput-image-preview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?