entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

workflows: only add "deleted" session message for "front" object (#84685) #926

Merged
fpeters merged 1 commits from wip/84685-do-not-add-deleted-session-message-deep-down into main 2023-12-15 09:20:37 +01:00
Conversation 0 Commits 1 Files Changed 3 +71 -1
fpeters commented 2023-12-13 16:55:07 +01:00
Owner
Copy Link

(not for objects down the external workflow calls)

(not for objects down the external workflow calls)
fpeters force-pushed wip/84685-do-not-add-deleted-session-message-deep-down from b695542478 to c1f4278184 2023-12-13 17:09:40 +01:00 Compare
fpeters changed title from WIP: workflows: only add "deleted" session message for "front" object (#84685) to workflows: only add "deleted" session message for "front" object (#84685) 2023-12-13 18:39:19 +01:00
tnoel requested changes 2023-12-14 11:23:11 +01:00
wcs/workflows.py Outdated
@ -153,0 +153,4 @@
get_request()
and get_response().filter.get('in_backoffice')
and len(get_publisher().workflow_execution_stack) < 2
):
tnoel commented 2023-12-14 11:23:05 +01:00
Owner
Copy Link

Pour qu'on comprenne mieux j'aurai mis la condition « if len(get_publisher().workflow_execution_stack) < 2 » en dessous, au niveau du block qui pose un get_session().message. Parce que là en cas de workflow externe on se retrouve dans else qui fait le url = get_publisher().get_frontoffice_url() et c'est bizarre (sans impact, mais bizarre).

Je sais je pinaille.

Pour qu'on comprenne mieux j'aurai mis la condition « if len(get_publisher().workflow_execution_stack) < 2 » en dessous, au niveau du block qui pose un get_session().message. Parce que là en cas de workflow externe on se retrouve dans else qui fait le url = get_publisher().get_frontoffice_url() et c'est bizarre (sans impact, mais bizarre). Je sais je pinaille.
fpeters commented 2023-12-14 11:57:12 +01:00
Author
Owner
Copy Link

Ok j'ai réécrit différemment cette partie.

Ok j'ai réécrit différemment cette partie.
tnoel marked this conversation as resolved
fpeters force-pushed wip/84685-do-not-add-deleted-session-message-deep-down from c1f4278184 to 015db13ceb 2023-12-14 11:39:36 +01:00 Compare
fpeters force-pushed wip/84685-do-not-add-deleted-session-message-deep-down from 015db13ceb to 5b4345b416 2023-12-14 11:49:29 +01:00 Compare
fpeters requested review from tnoel 2023-12-14 12:11:21 +01:00
tnoel approved these changes 2023-12-14 14:11:55 +01:00
tnoel left a comment
Owner
Copy Link

C'est parfait ainsi (pour moi).

C'est parfait ainsi (pour moi).
fpeters merged commit d3822a80b9 into main 2023-12-15 09:20:37 +01:00
fpeters deleted branch wip/84685-do-not-add-deleted-session-message-deep-down 2023-12-15 09:20:37 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#926
No description provided.
Delete Branch "wip/84685-do-not-add-deleted-session-message-deep-down"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?