entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

workflows: fix global confirmation when there are timeout triggers (#82894) #788

Merged
fpeters merged 1 commits from wip/82894-global-confirmation-trigger into main 2023-10-27 11:59:32 +02:00
Conversation 0 Commits 1 Files Changed 2 +3 -2
fpeters commented 2023-10-27 11:45:54 +02:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2023-10-27 11:45:55 +02:00
fpeters reviewed 2023-10-27 11:47:03 +02:00
wcs/workflows.py
@ -972,4 +974,2 @@
functions = [x for x in roles if x in self.roles]
roles = [x for x in roles if x not in self.roles]
action.require_confirmation = trigger.require_confirmation
action.confirmation_text = trigger.confirmation_text
fpeters commented 2023-10-27 11:47:03 +02:00
Author
Owner
Copy Link

En fin de boucle on n'était plus nécessairement sur le bon trigger; donc là je déplace dans la boucle, et hop.

En fin de boucle on n'était plus nécessairement sur le bon trigger; donc là je déplace dans la boucle, et hop.
tnoel approved these changes 2023-10-27 11:47:56 +02:00
nroche approved these changes 2023-10-27 11:48:29 +02:00
fpeters merged commit dd8dfdcf20 into main 2023-10-27 11:59:32 +02:00
fpeters deleted branch wip/82894-global-confirmation-trigger 2023-10-27 12:18:14 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
nroche
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#788
No description provided.
Delete Branch "wip/82894-global-confirmation-trigger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?