entrouvert/wcs
entrouvert
/
wcs
15
1
Fork 0
Code Issues Pull Requests 24 Releases Activity

WIP: create a VisitedObjects class and table to reduce Sessions table usage (#81183) #624

Draft
pducroquet wants to merge 12 commits from wip/80613-visited-objects into main
pull from: wip/80613-visited-objects
merge into: entrouvert:main
Conversation 0 Commits 12 Files Changed 6 +142 -96
pducroquet commented 2023-08-29 14:03:30 +02:00
Owner
Copy Link
No description provided.
pducroquet force-pushed wip/80613-visited-objects from a87ff0538c to f337760d00 2023-08-29 14:03:47 +02:00 Compare
pducroquet force-pushed wip/80613-visited-objects from c42c383b19 to 5f648b5ef5 2023-08-29 15:48:40 +02:00 Compare
pducroquet added 1 commit 2023-08-29 16:03:23 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
b7799c1975 further replacements needed
pducroquet added 1 commit 2023-08-29 16:25:05 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
96783ee35a fix quoting
pducroquet added 1 commit 2023-08-29 16:31:22 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
3c44ae856c test migrate ...
pducroquet added 1 commit 2023-08-29 17:06:17 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
1445a2ff95 is it what's missing?
pducroquet added 1 commit 2023-08-29 20:41:39 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
7c75953641 I test what I can...
pducroquet added 1 commit 2023-08-30 10:18:58 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
8eb21b2549 fix migrate
pducroquet added 1 commit 2023-08-30 10:35:43 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
b2676dda75 add casts and not exists
pducroquet added 1 commit 2023-08-30 10:53:28 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
8cdfa9ed0c fix function taking object without using the key
pducroquet added 1 commit 2023-08-30 11:12:57 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
7ce5b69b63 fix serialisation, fix get_visited_objects query build
pducroquet added 1 commit 2023-08-30 11:33:33 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
9a13837fe6 missing parenthesis for cast
pducroquet added 1 commit 2023-08-30 11:48:03 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
3f5a077cd6 another missing cast
fpeters reviewed 2023-09-04 09:29:36 +02:00
wcs/backoffice/management.py
@ -629,3 +629,3 @@
workflows = {}
session = get_session()
visited_objects = session.get_visited_objects(exclude_user=session.user)
visited_objects = sql.VisitedObject.get_visited_objects(exclude_user=session.user)
fpeters commented 2023-09-04 09:29:36 +02:00
Owner
Copy Link

Plutôt garder les méthodes sur l'objet session, ce qui permettra de garder les modifications localisées. (ça résoudra l'échec sur test_sessions.test_sessions_visiting_objects par la même occasion).

Plutôt garder les méthodes sur l'objet session, ce qui permettra de garder les modifications localisées. (ça résoudra l'échec sur test_sessions.test_sessions_visiting_objects par la même occasion).
fpeters reviewed 2023-09-04 09:32:01 +02:00
wcs/sql.py
@ -3221,0 +3277,4 @@
if visitor:
visitor_key = visitor
else:
visitor_key = ""
fpeters commented 2023-09-04 09:32:01 +02:00
Owner
Copy Link

Curieux la configuration pre-commit devrait éviter ça, utiliser des single quotes.

Curieux la configuration pre-commit devrait éviter ça, utiliser des single quotes.
fpeters changed title from WIP: create a VisitedObjects class and table to reduce Sessions table usage (#80613) to WIP: create a VisitedObjects class and table to reduce Sessions table usage (#81183) 2023-09-13 19:21:42 +02:00
Some checks failed
gitea/wcs/pipeline/head There was a failure building this commit
Details
This pull request has changes conflicting with the target branch.
  • wcs/sessions.py
  • wcs/sql.py
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#624
No description provided.
Delete Branch "wip/80613-visited-objects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?