entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 41 Releases Activity

misc: always set empty display/structured when there is no value (#66609) #469

Merged
fpeters merged 2 commits from wip/66609-conditional-checkboxes into main 2023-07-14 09:04:18 +02:00
Conversation 1 Commits 2 Files Changed 4 +90 -11
fpeters commented 2023-07-09 15:14:17 +02:00
Owner
Copy Link
No description provided.
fpeters force-pushed wip/66609-conditional-checkboxes from 0cbf50c837 to 01f976d134 2023-07-09 15:43:06 +02:00 Compare
fpeters force-pushed wip/66609-conditional-checkboxes from 01f976d134 to 99a0682c26 2023-07-09 15:45:24 +02:00 Compare
fpeters force-pushed wip/66609-conditional-checkboxes from 99a0682c26 to 3163245fbe 2023-07-09 16:17:53 +02:00 Compare
fpeters changed title from WIP: misc: always set empty display/structured when there is no value (#66609) to misc: always set empty display/structured when there is no value (#66609) 2023-07-09 16:58:33 +02:00
fpeters reviewed 2023-07-09 16:58:51 +02:00
wcs/fields.py Outdated
@ -691,3 +690,1 @@
data['%s_display' % self.id] = display_value
elif '%s_display' % self.id in data:
del data['%s_display' % self.id]
data['%s_display' % self.id] = display_value or None
fpeters commented 2023-07-09 16:58:51 +02:00
Author
Owner
Copy Link

Cette manière de supprimer du dictionnaire plutôt que mettre une valeur vide date de l'introduction des sources de données (et des valeurs ..._display) (#1459), "évidemment" il n'y a pas d'explication particulière sur le sujet mais ça fonctionne très bien en mettant simplement None.

Cette manière de supprimer du dictionnaire plutôt que mettre une valeur vide date de l'introduction des sources de données (et des valeurs `..._display`) (#1459), "évidemment" il n'y a pas d'explication particulière sur le sujet mais ça fonctionne très bien en mettant simplement None.
lguerin approved these changes 2023-07-10 09:23:14 +02:00
Dismissed
fpeters force-pushed wip/66609-conditional-checkboxes from 3163245fbe to bcb483daec 2023-07-10 10:54:29 +02:00 Compare
fpeters commented 2023-07-10 10:54:45 +02:00
Author
Owner
Copy Link

J'ai ajouté un commit avec le test de #78583.

J'ai ajouté un commit avec le test de #78583.
lguerin dismissed lguerin’s review 2023-07-10 11:45:13 +02:00
lguerin approved these changes 2023-07-10 11:45:19 +02:00
fpeters merged commit f0b1c9ed5b into main 2023-07-14 09:04:18 +02:00
fpeters deleted branch wip/66609-conditional-checkboxes 2023-07-14 09:04:18 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#469
No description provided.
Delete Branch "wip/66609-conditional-checkboxes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?