entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 35 Releases Activity

datasources: auto agenda ds & dynamic meeting type (#77497) #405

Merged
lguerin merged 1 commits from wip/77497-chrono-ds-dynamic into main 2023-06-23 08:45:15 +02:00
Conversation 0 Commits 1 Files Changed 2 +17
lguerin commented 2023-06-19 11:38:27 +02:00
Owner
Copy Link
No description provided.
tnoel requested changes 2023-06-19 11:59:03 +02:00
wcs/data_sources.py Outdated
@ -1171,1 +1171,4 @@
)
agenda_data.append(
{
'slug': 'agenda-%s-%s-mt-dynamic' % (agenda['kind'], agenda['id']),
tnoel commented 2023-06-19 11:58:56 +02:00
Owner
Copy Link

On pourrait imaginer un conflit de slug ici, car on a plus bas dans le code un

'slug': 'agenda-%s-%s-mt-%s' % (agenda['kind'], agenda['id'], meetingtype['id'])

où meetingtype['id'] pourrait être "dynamic" si quelqu'un nomme ainsi son type de rendez-vous...

Peut-être qu'un « agenda-%s-%s-mtdynamic » serait ici utile...

On pourrait imaginer un conflit de slug ici, car on a plus bas dans le code un 'slug': 'agenda-%s-%s-mt-%s' % (agenda['kind'], agenda['id'], meetingtype['id']) où meetingtype['id'] pourrait être "dynamic" si quelqu'un nomme ainsi son type de rendez-vous... Peut-être qu'un « agenda-%s-%s-mtdynamic » serait ici utile...
lguerin commented 2023-06-19 12:23:24 +02:00
Author
Owner
Copy Link

yes bien vu

yes bien vu
tnoel marked this conversation as resolved
lguerin force-pushed wip/77497-chrono-ds-dynamic from 7ec6534e69 to 074bb7e5a1 2023-06-19 12:23:59 +02:00 Compare
lguerin requested review from tnoel 2023-06-19 12:24:07 +02:00
tnoel approved these changes 2023-06-19 12:28:15 +02:00
lguerin force-pushed wip/77497-chrono-ds-dynamic from 074bb7e5a1 to 7008d3061a 2023-06-23 08:03:21 +02:00 Compare
lguerin merged commit db099e53c8 into main 2023-06-23 08:45:15 +02:00
lguerin deleted branch wip/77497-chrono-ds-dynamic 2023-06-23 08:45:15 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#405
No description provided.
Delete Branch "wip/77497-chrono-ds-dynamic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?