entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 29 Releases Activity

JS: init live validation on blockwidget's widgets when row is added (#78227) #367

Merged
tjund merged 1 commits from wip/78227-BlockWidget-liveValidation into main 2023-06-14 16:25:13 +02:00
Conversation 2 Commits 1 Files Changed 1 +13 -4
tjund commented 2023-06-12 18:09:18 +02:00
Owner
Copy Link
No description provided.
tjund commented 2023-06-12 18:12:09 +02:00
Author
Owner
Copy Link

Où je découvre que la méthode trigger de jQuery n'est pas compatible avec addEventListener, j'ai donc ajouté un customEvent natif 'wcs:block-row-added'.

Où je découvre que la méthode trigger de jQuery n'est pas compatible avec addEventListener, j'ai donc ajouté un customEvent natif 'wcs:block-row-added'.
fpeters approved these changes 2023-06-13 16:29:00 +02:00
fpeters left a comment
Owner
Copy Link

Plutôt "forms:", ou "blocks:", que "JS:" comme préfixe au message de commit.

Plutôt "forms:", ou "blocks:", que "JS:" comme préfixe au message de commit.
wcs/qommon/static/js/qommon.forms.js Outdated
@ -755,2 +755,3 @@
add_js_behaviours($('[data-field-id="' + block_id + '"]'));
$('form').trigger('wcs:block-row-added');
$form.trigger('wcs:block-row-added');
$form[0].dispatchEvent(new CustomEvent('wcs:block-row-added', { detail: { newBlock: $new_block[0] } } ))
fpeters commented 2023-06-13 16:27:55 +02:00
Owner
Copy Link

Par uniformité avec le code environnant j'aurais laissé un point-virgule; mais total détail.

Par uniformité avec le code environnant j'aurais laissé un point-virgule; mais total détail.
tjund force-pushed wip/78227-BlockWidget-liveValidation from d0f9542e5b to d122cac45a 2023-06-14 15:54:38 +02:00 Compare
tjund commented 2023-06-14 16:25:05 +02:00
Author
Owner
Copy Link

semi-colon et message corrigé.

semi-colon et message corrigé.
tjund merged commit 068ebdea27 into main 2023-06-14 16:25:13 +02:00
tjund deleted branch wip/78227-BlockWidget-liveValidation 2023-06-14 16:25:13 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#367
No description provided.
Delete Branch "wip/78227-BlockWidget-liveValidation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?