entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: do not save prefilling data on initial visit (#75848) #1407

Merged
fpeters merged 1 commits from wip/75848-do-not-save-prefill-first-visit into main 2024-04-15 16:52:08 +02:00
Conversation 0 Commits 1 Files Changed 3 +10 -23
fpeters commented 2024-04-14 14:59:33 +02:00
Owner
Copy Link

(pour build, voir s'il y a des pièges avec cette suggestion)

réponse : il y a le cas des démarches avec des données calculées en première page, qui doivent provoquer un brouillon (situation détectée par test_computed_field_set_data) mais à part ça, ça va.

(pour build, voir s'il y a des pièges avec cette suggestion) réponse : il y a le cas des démarches avec des données calculées en première page, qui doivent provoquer un brouillon (situation détectée par test_computed_field_set_data) mais à part ça, ça va.
fpeters added 1 commit 2024-04-14 14:59:33 +02:00
gitea/wcs/pipeline/head There was a failure building this commit Details
23e08a169c misc: do not save prefilling data on initial visit (#75848)
fpeters force-pushed wip/75848-do-not-save-prefill-first-visit from 23e08a169c to 15d2939e52 2024-04-14 15:19:52 +02:00 Compare
fpeters force-pushed wip/75848-do-not-save-prefill-first-visit from 15d2939e52 to fc6a41549d 2024-04-15 13:49:57 +02:00 Compare
fpeters reviewed 2024-04-15 13:59:07 +02:00
wcs/forms/root.py
@ -602,1 +602,3 @@
self, page, page_change=True, page_error_messages=None, submit_button=None, transient_formdata=None
self,
page,
arrival=False,
fpeters commented 2024-04-15 13:58:48 +02:00
Author
Owner
Copy Link

Ce nouveau paramètre, pour dire qu'on arrive sur la démarche.

Ce nouveau paramètre, pour dire qu'on arrive sur la démarche.
wcs/qommon/http_request.py
@ -214,16 +214,6 @@ class HTTPRequest(quixote.http_request.HTTPRequest):
user_agent = self.get_environ('HTTP_USER_AGENT', '').lower()
return bool('bot' in user_agent or 'crawl' in user_agent)
def is_from_application(self):
fpeters commented 2024-04-15 13:59:02 +02:00
Author
Owner
Copy Link

On n'a plus besoin de ça.

On n'a plus besoin de ça.
fpeters changed title from WIP: misc: do not save prefilling data on initial visit (#75848) to misc: do not save prefilling data on initial visit (#75848) 2024-04-15 13:59:19 +02:00
lguerin approved these changes 2024-04-15 16:33:04 +02:00
fpeters merged commit ae2cc0cfe9 into main 2024-04-15 16:52:08 +02:00
fpeters deleted branch wip/75848-do-not-save-prefill-first-visit 2024-04-15 16:52:08 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1407
No description provided.
Delete Branch "wip/75848-do-not-save-prefill-first-visit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?