entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 36 Releases Activity

workflows: do not feed nul bytes to FTS (#88716) #1318

Merged
fpeters merged 1 commits from wip/88716-fts-nul-byte into main 2024-03-29 08:33:59 +01:00
Conversation 0 Commits 1 Files Changed 2 +21 -1
fpeters commented 2024-03-26 16:55:23 +01:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-03-26 16:55:23 +01:00
gitea/wcs/pipeline/head This commit looks good Details
158747f99c workflows: do not feed nul bytes to FTS (#88716)
fpeters changed title from WIP: workflows: do not feed nul bytes to FTS (#88716) to workflows: do not feed nul bytes to FTS (#88716) 2024-03-26 17:03:40 +01:00
pmarillonnet approved these changes 2024-03-27 10:54:57 +01:00
pmarillonnet left a comment
Owner
Copy Link

Du détail mais je verrais bien un autre message de commit puisque le commit fait un peu plus que ce que le message actuel semble indiquer.

Du détail mais je verrais bien un autre message de commit puisque le commit fait un peu plus que ce que le message actuel semble indiquer.
wcs/workflows.py Outdated
@ -361,3 +361,3 @@
# don't include parts with no content or restricted visibility
return ''
return misc.html2text(self.view() or '')
illegal_fts_chars = re.compile(r'[\x00-\x1F]')
pmarillonnet commented 2024-03-27 10:53:42 +01:00
Owner
Copy Link

Ok, on dégage les trente et un premiers code points qui correspondent à des caractères de contrôle.

Edit: en fait les trente-deux premiers :)

Ok, on dégage les trente et un premiers _code points_ qui correspondent à des caractères de contrôle. Edit: en fait les trente-deux premiers :)
fpeters commented 2024-03-27 11:04:22 +01:00
Author
Owner
Copy Link

Je me suis laissé emporter :) J'ai renommé en "workflows: do not feed ascii control characters to FTS ".

Je me suis laissé emporter :) J'ai renommé en "workflows: do not feed ascii control characters to FTS ".
pmarillonnet commented 2024-03-27 11:45:51 +01:00
Owner
Copy Link

Je me suis laissé emporter :) J'ai renommé en "workflows: do not feed ascii control characters to FTS ".

Top, merci.

> Je me suis laissé emporter :) J'ai renommé en "workflows: do not feed ascii control characters to FTS ". Top, merci.
fpeters force-pushed wip/88716-fts-nul-byte from 158747f99c to 13d46a4ff2 2024-03-27 11:03:46 +01:00 Compare
fpeters merged commit 990dde7060 into main 2024-03-29 08:33:59 +01:00
fpeters deleted branch wip/88716-fts-nul-byte 2024-03-29 08:33:59 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
pmarillonnet
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1318
No description provided.
Delete Branch "wip/88716-fts-nul-byte"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?