entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 45 Releases Activity

misc: report an error on unknown custom view (#88535) #1302

Merged
fpeters merged 1 commits from wip/88535-report-error-on-unknown-custom-view into main 2024-03-29 08:32:49 +01:00
Conversation 0 Commits 1 Files Changed 2 +8
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/test_formdata.py
View File

@ -2241,10 +2241,15 @@ def test_lazy_global_forms(pub):
)
assert tmpl.render(context) == '7,8,9,10,'
pub.loggederror_class.wipe()
tmpl = Template('{{forms|objects:"foobarlazy"|with_custom_view:"private-form-view"|count}}')
assert tmpl.render(context) == '0'
assert [x.summary for x in pub.loggederror_class.select()] == ['Unknown custom view "private-form-view"']
pub.loggederror_class.wipe()
tmpl = Template('{{forms|objects:"foobarlazy"|with_custom_view:"unknown"|count}}')
assert tmpl.render(context) == '0'
assert [x.summary for x in pub.loggederror_class.select()] == ['Unknown custom view "unknown"']
custom_view4 = pub.custom_view_class()
custom_view4.title = 'unknown filter'
@ -2253,6 +2258,8 @@ def test_lazy_global_forms(pub):
custom_view4.filters = {'filter-42': 'on', 'filter-42-value': 'foo', 'filter-foobar': 'baz'}
custom_view4.visibility = 'any'
custom_view4.store()
pub.loggederror_class.wipe()
tmpl = Template('{{forms|objects:"foobarlazy"|with_custom_view:"unknown-filter"|count}}')
assert tmpl.render(context) == '0'
assert pub.loggederror_class.count() == 2

1
wcs/variables.py
View File

@ -176,6 +176,7 @@ class LazyFormDefObjectsManager:
try:
custom_view = get_publisher().custom_view_class.select(lookup_criterias)[0]
except IndexError:
self.report_error(_('Unknown custom view "%(slug)s"') % {'slug': custom_view_slug})
return self.none()
return self._clone(self._criterias + custom_view.get_criterias(), order_by=custom_view.order_by)