entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

workflows: remove stored prefill from workflow variable formdef (#87994) #1247

Merged
fpeters merged 1 commits from wip/87994-prefill-variable-formdef into main 2024-03-15 07:23:31 +01:00
Conversation 0 Commits 1 Files Changed 2 +27
fpeters commented 2024-03-11 10:30:58 +01:00
Owner
Copy Link
No description provided.
fpeters force-pushed wip/87994-prefill-variable-formdef from 1ff789159e to a2a78fbd2b 2024-03-11 11:49:03 +01:00 Compare
fpeters changed title from WIP: workflows: remove stored prefill from workflow variable formdef (#87994) to workflows: remove stored prefill from workflow variable formdef (#87994) 2024-03-11 12:57:08 +01:00
tnoel reviewed 2024-03-11 17:36:14 +01:00
wcs/workflows.py Outdated
@ -733,0 +736,4 @@
changed |= field.migrate()
if getattr(field, 'prefill', None):
changed = True
delattr(field, 'prefill')
tnoel commented 2024-03-11 17:36:14 +01:00
Owner
Copy Link

Juste pour ma curiosité, j'imagine bien que le delattr fait le travail, mais pourquoi pas field.prefill = None ?

Juste pour ma curiosité, j'imagine bien que le delattr fait le travail, mais pourquoi pas `field.prefill = None` ?
fpeters commented 2024-03-11 17:41:06 +01:00
Author
Owner
Copy Link

Ça me semblait plus clairement indiquer que "cet attribut n'existe plus", (vs "cet attribut est vidé"), mais ça revient au même, je viens de le changer en = None + commentaire pour expliquer la situation.

Ça me semblait plus clairement indiquer que "cet attribut n'existe plus", (vs "cet attribut est vidé"), mais ça revient au même, je viens de le changer en = None + commentaire pour expliquer la situation.
fpeters force-pushed wip/87994-prefill-variable-formdef from a2a78fbd2b to b31e95ff93 2024-03-11 17:40:48 +01:00 Compare
tnoel approved these changes 2024-03-11 17:43:41 +01:00
fpeters merged commit 7b258dfdc6 into main 2024-03-15 07:23:31 +01:00
fpeters deleted branch wip/87994-prefill-variable-formdef 2024-03-15 07:23:31 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1247
No description provided.
Delete Branch "wip/87994-prefill-variable-formdef"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?