entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: do not decorate uploaded HTML files (#87331) #1181

Merged
fpeters merged 1 commits from wip/87331-serve-uploaded-html-as-raw-html into main 2024-03-01 12:17:56 +01:00
Conversation 0 Commits 1 Files Changed 10 +52 -15
fpeters commented 2024-02-22 16:40:19 +01:00
Owner
Copy Link
No description provided.
fpeters changed title from WIP: misc: do not decorate uploaded HTML files (#87331) to misc: do not decorate uploaded HTML files (#87331) 2024-02-23 21:25:10 +01:00
tnoel requested changes 2024-02-29 11:23:54 +01:00
Dismissed
wcs/compat.py Outdated
@ -162,3 +162,3 @@
# clients don't like to receive content with a 304
return ''
if response.content_type != 'text/html':
if response.content_type != 'text/html' or 'raw' in (getattr(response, 'filter') or {}):
tnoel commented 2024-02-29 11:23:49 +01:00
Owner
Copy Link

Ça laisse passer un 'raw': False. Aussi, éviter tout risque de getattr qui foire avec getattr(response, 'filter', {}). Donc je dirais plutôt:

... or (getattr(response, 'filter', {}) or {}).get('raw'):

tout en étant conscient que je pinaille.

Ça laisse passer un 'raw': False. Aussi, éviter tout risque de getattr qui foire avec getattr(response, 'filter', {}). Donc je dirais plutôt: ` ... or (getattr(response, 'filter', {}) or {}).get('raw'):` tout en étant conscient que je pinaille.
fpeters commented 2024-02-29 12:37:46 +01:00
Author
Owner
Copy Link

... or (getattr(response, 'filter', {}) or {}).get('raw'):

Signe qu'il faut arrêter d'abuser de ce pauvre dictionnaire, je viens d'ajouter un commit (38656dc2e7) pour plutôt utiliser un attribut dédié sur l'objet response.

> ... or (getattr(response, 'filter', {}) or {}).get('raw'): Signe qu'il faut arrêter d'abuser de ce pauvre dictionnaire, je viens d'ajouter un commit (https://git.entrouvert.org/entrouvert/wcs/commit/38656dc2e709756367aa6d7847265214deb341f6) pour plutôt utiliser un attribut dédié sur l'objet response.
tnoel commented 2024-03-01 11:04:34 +01:00
Owner
Copy Link

Et c'est super mieux ainsi.

Et c'est super mieux ainsi.
tnoel marked this conversation as resolved
fpeters force-pushed wip/87331-serve-uploaded-html-as-raw-html from fb82f36771 to 38656dc2e7 2024-02-29 12:28:43 +01:00 Compare
fpeters requested review from tnoel 2024-02-29 12:37:50 +01:00
tnoel approved these changes 2024-03-01 11:04:54 +01:00
fpeters force-pushed wip/87331-serve-uploaded-html-as-raw-html from 38656dc2e7 to b48214feac 2024-03-01 11:13:16 +01:00 Compare
fpeters merged commit b48214feac into main 2024-03-01 12:17:56 +01:00
fpeters deleted branch wip/87331-serve-uploaded-html-as-raw-html 2024-03-01 12:17:56 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1181
No description provided.
Delete Branch "wip/87331-serve-uploaded-html-as-raw-html"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?