entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: record an error if action_button has no label parameter (#87258) #1172

Merged
fpeters merged 2 commits from wip/87258-action-button-label into main 2024-02-23 19:02:52 +01:00
Conversation 0 Commits 2 Files Changed 2 +46 -3
fpeters commented 2024-02-21 10:24:12 +01:00
Owner
Copy Link
No description provided.
fpeters changed title from WIP: misc: record an error if action_button has no label parameter (#87258) to misc: record an error if action_button has no label parameter (#87258) 2024-02-21 11:19:56 +01:00
lguerin reviewed 2024-02-21 16:25:57 +01:00
wcs/qommon/templatetags/qommon.py Outdated
@ -1273,3 +1278,3 @@
@register.simple_tag(takes_context=True)
def make_public_url(context, url):
def make_public_url(context, url=None):
lguerin commented 2024-02-21 16:25:53 +01:00
Owner
Copy Link

pourquoi ce changement ?

pourquoi ce changement ?
bdauvergne commented 2024-02-21 16:40:21 +01:00
Owner
Copy Link

Pour éviter la même erreur que sur action_button je suppose, ça mériterait peut-être son propre patch.

Pour éviter la même erreur que sur action_button je suppose, ça mériterait peut-être son propre patch.
fpeters commented 2024-02-21 17:14:56 +01:00
Author
Owner
Copy Link

Oui en faisant le tour j'ai vu cet autre templatetag qui pouvait être concerné, j'ai maintenant isolé ça dans son propre commit.

Oui en faisant le tour j'ai vu cet autre templatetag qui pouvait être concerné, j'ai maintenant isolé ça dans son propre commit.
fpeters force-pushed wip/87258-action-button-label from 2296ab1174 to b1c7b6e0ed 2024-02-21 17:14:30 +01:00 Compare
lguerin approved these changes 2024-02-21 17:20:51 +01:00
fpeters merged commit 80046e82a1 into main 2024-02-23 19:02:52 +01:00
fpeters deleted branch wip/87258-action-button-label 2024-02-23 19:02:53 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1172
No description provided.
Delete Branch "wip/87258-action-button-label"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?