entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: fix duplication of form with test but no mocked webservice (#87057) #1151

Merged
fpeters merged 1 commits from wip/87057-duplicate-with-test into main 2024-02-16 13:46:31 +01:00
Conversation 0 Commits 1 Files Changed 2 +27
fpeters commented 2024-02-16 13:12:54 +01:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-02-16 13:12:55 +01:00
fpeters changed title from WIP: misc: fix duplication of form with test but no mocked webservice (#87057) to misc: fix duplication of form with test but no mocked webservice (#87057) 2024-02-16 13:20:53 +01:00
fpeters reviewed 2024-02-16 13:22:52 +01:00
wcs/testdef.py
@ -59,6 +59,8 @@ class TestDefXmlProxy(XmlStorableObject):
# prevent pytest from trying to collect this class
__test__ = False
_webservice_responses = []
fpeters commented 2024-02-16 13:22:52 +01:00
Author
Owner
Copy Link

L'importation fait :

        for field, dummy in TestDefXmlProxy.XML_NODES:  # pylint: disable=not-an-iterable
            if hasattr(testdef_xml, field):
                setattr(testdef, field, getattr(testdef_xml, field))

        testdef.store()

        for response in testdef._webservice_responses:
            response.testdef_id = testdef.id
            response.store()

et comme il n'y avait pas d'attribut _webservice_responses défini quand ça arrivait sur la deuxième boucle ça plantait.

L'importation fait : ``` for field, dummy in TestDefXmlProxy.XML_NODES: # pylint: disable=not-an-iterable if hasattr(testdef_xml, field): setattr(testdef, field, getattr(testdef_xml, field)) testdef.store() for response in testdef._webservice_responses: response.testdef_id = testdef.id response.store() ``` et comme il n'y avait pas d'attribut _webservice_responses défini quand ça arrivait sur la deuxième boucle ça plantait.
lguerin approved these changes 2024-02-16 13:43:58 +01:00
fpeters merged commit 3c08c9b524 into main 2024-02-16 13:46:31 +01:00
fpeters deleted branch wip/87057-duplicate-with-test 2024-02-16 13:46:31 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1151
No description provided.
Delete Branch "wip/87057-duplicate-with-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?