entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: treat more invalid input as 0 in |decimal (#86924) #1137

Merged
fpeters merged 1 commits from wip/86924-decimal-list-value-error into main 2024-02-13 17:22:56 +01:00
Conversation 0 Commits 1 Files Changed 2 +3 -1
fpeters commented 2024-02-13 17:07:50 +01:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-02-13 17:07:51 +01:00
fpeters reviewed 2024-02-13 17:08:32 +01:00
tests/test_templates.py
@ -449,6 +449,8 @@ def test_decimal_templatetag(pub):
assert tmpl.render({'plop': 12345.678}) == '12345.678'
assert tmpl.render({'plop': None}) == '0'
assert tmpl.render({'plop': 0}) == '0'
assert tmpl.render({'plop': ['foo', 'bar']}) == '0'
fpeters commented 2024-02-13 17:08:02 +01:00
Author
Owner
Copy Link

Ça correspond à l'erreur dans le ticket.

Ça correspond à l'erreur dans le ticket.
tests/test_templates.py
@ -450,2 +450,4 @@
assert tmpl.render({'plop': None}) == '0'
assert tmpl.render({'plop': 0}) == '0'
assert tmpl.render({'plop': ['foo', 'bar']}) == '0'
assert tmpl.render({'plop': ['a', 'b', 'c']}) == '0'
fpeters commented 2024-02-13 17:08:30 +01:00
Author
Owner
Copy Link

Ça fait aussi un ValueError mais un autre, donc je l'ai laissé,

E           ValueError: sign must be an integer with the value 0 or 1
Ça fait aussi un ValueError mais un autre, donc je l'ai laissé, ``` E ValueError: sign must be an integer with the value 0 or 1 ```
fpeters changed title from WIP: misc: treat more invalid input as 0 in |decimal (#86924) to misc: treat more invalid input as 0 in |decimal (#86924) 2024-02-13 17:20:10 +01:00
smihai approved these changes 2024-02-13 17:21:36 +01:00
fpeters merged commit cdc9ef7110 into main 2024-02-13 17:22:56 +01:00
fpeters deleted branch wip/86924-decimal-list-value-error 2024-02-13 17:22:56 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
smihai
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1137
No description provided.
Delete Branch "wip/86924-decimal-list-value-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?