entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: skip hidden pages when editing from a given page (#78219) #1128

Merged
fpeters merged 2 commits from wip/78219-edit-from-invisible-page into main 2024-02-13 11:35:09 +01:00
Conversation 0 Commits 2 Files Changed 3 +90 -9
fpeters commented 2024-02-11 16:14:15 +01:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-02-11 16:14:15 +01:00
fpeters force-pushed wip/78219-edit-from-invisible-page from 91ff9fbaaf to 97d4bd7d2d 2024-02-11 18:00:41 +01:00 Compare
fpeters force-pushed wip/78219-edit-from-invisible-page from 97d4bd7d2d to ad48ffb759 2024-02-11 18:18:19 +01:00 Compare
fpeters changed title from WIP: misc: skip hidden pages when editing from a given page (#78219) to misc: skip hidden pages when editing from a given page (#78219) 2024-02-12 15:28:45 +01:00
lguerin reviewed 2024-02-13 10:32:10 +01:00
tests/form_pages/test_all.py Outdated
@ -5740,0 +5750,4 @@
resp.form['f6'] = 'another last change'
resp = resp.form.submit('submit')
formdata.refresh_from_storage()
assert formdata.data == {'2': 'a', '4': 'other change', '6': 'another last change'}
lguerin commented 2024-02-13 10:27:58 +01:00
Owner
Copy Link

rien à voir, mais le test s'appelle test_form_edit_single_page mais teste les modes single et partial, peut-être le renommer ?

rien à voir, mais le test s'appelle `test_form_edit_single_page` mais teste les modes single et partial, peut-être le renommer ?
fpeters commented 2024-02-13 11:17:58 +01:00
Author
Owner
Copy Link

Je l'ai renommé.

Je l'ai renommé.
wcs/forms/root.py Outdated
@ -1079,3 +1078,4 @@
if self.edit_action.operation_mode == 'single':
break
edit_pages = [x for x in edit_pages if x not in hidden_pages]
if not edit_pages:
lguerin commented 2024-02-13 10:31:53 +01:00
Owner
Copy Link

petit doute, est-ce qu'il y a un test en mode single et partial, pour le cas où il n'y a pas de page visible ?

petit doute, est-ce qu'il y a un test en mode single et partial, pour le cas où il n'y a pas de page visible ?
fpeters commented 2024-02-13 11:18:31 +01:00
Author
Owner
Copy Link

Ça n'était en effet pas testé, je l'ai ajouté.

Et j'ai ajouté un test du mode "partial" dans le backoffice, dans un commit séparé.

Ça n'était en effet pas testé, je l'ai ajouté. Et j'ai ajouté un test du mode "partial" dans le backoffice, dans un commit séparé.
fpeters force-pushed wip/78219-edit-from-invisible-page from ad48ffb759 to fd254de52b 2024-02-13 10:57:27 +01:00 Compare
lguerin approved these changes 2024-02-13 11:25:35 +01:00
fpeters merged commit b821e3bd07 into main 2024-02-13 11:35:09 +01:00
fpeters deleted branch wip/78219-edit-from-invisible-page 2024-02-13 11:35:09 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1128
No description provided.
Delete Branch "wip/78219-edit-from-invisible-page"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?