entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

tests i18n qui ne passent pas en isolation (#86736) #1112

Merged
fpeters merged 2 commits from wip/86736-tests-i-n-qui-ne-passent-pas-en into main 2024-02-09 07:26:21 +01:00
Conversation 0 Commits 2 Files Changed 2 +18 -25
vdeniaud commented 2024-02-08 16:57:56 +01:00
Owner
Copy Link
No description provided.
vdeniaud added 2 commits 2024-02-08 16:57:57 +01:00
gitea/wcs/pipeline/head This commit looks good Details
54e78443a6 tests: make i18n tests independant (#86736)
vdeniaud reviewed 2024-02-08 17:01:28 +01:00
tests/admin_pages/test_i18n.py
@ -32,6 +32,14 @@ def pub():
TranslatableMessage.do_table() # update table with selected languages
TranslatableMessage.wipe()
vdeniaud commented 2024-02-08 16:59:45 +01:00
Author
Owner
Copy Link

Wipe du SQL pour éviter les erreurs obtenues à cause de xdist

Wipe du SQL pour éviter les erreurs obtenues à cause de xdist
tests/admin_pages/test_i18n.py
@ -35,0 +38,4 @@
BlockDef.wipe()
Category.wipe()
CardDef.wipe()
MailTemplate.wipe()
vdeniaud commented 2024-02-08 17:00:22 +01:00
Author
Owner
Copy Link

Wipe de tous les objets XML pour s'assurer que les tests ne dépendent plus les uns de autres

Wipe de tous les objets XML pour s'assurer que les tests ne dépendent plus les uns de autres
tests/admin_pages/test_i18n.py
@ -161,3 +170,3 @@
resp = resp.form.submit('cancel').follow()
resp = resp.click('edit', index=0)
resp = resp.click('edit', href='/%s/' % msg.id)
assert resp.pyquery('.i18n-orig-string').text() == 'Email body'
vdeniaud commented 2024-02-08 16:58:58 +01:00
Author
Owner
Copy Link

Plantage en local sur cette ligne, car le click est fait sur 'Email subject'

Plantage en local sur cette ligne, car le click est fait sur 'Email subject'
wcs/backoffice/i18n.py
@ -62,4 +62,2 @@
if not get_publisher().has_i18n_enabled():
raise errors.TraversalError()
if TranslatableMessage.count() == 0:
vdeniaud commented 2024-02-08 17:01:23 +01:00
Author
Owner
Copy Link

Sinon fail du test test_i18n_but_no_language, sur la ligne
resp = app.get('/backoffice/i18n/', status=200)
on se prend une 302

Sinon fail du test test_i18n_but_no_language, sur la ligne ```resp = app.get('/backoffice/i18n/', status=200)``` on se prend une 302
vdeniaud changed title from WIP: tests i18n qui ne passent pas en isolation (#86736) to tests i18n qui ne passent pas en isolation (#86736) 2024-02-08 17:15:04 +01:00
fpeters approved these changes 2024-02-09 07:26:15 +01:00
fpeters merged commit 54e78443a6 into main 2024-02-09 07:26:21 +01:00
fpeters deleted branch wip/86736-tests-i-n-qui-ne-passent-pas-en 2024-02-09 07:26:21 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1112
No description provided.
Delete Branch "wip/86736-tests-i-n-qui-ne-passent-pas-en"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?