entrouvert/wcs
entrouvert
/
wcs
14
1
Fork 0
Code Issues Pull Requests 34 Releases Activity

misc: consider hidden blocks as empty in form_details (#85977) #1056

Merged
fpeters merged 1 commits from wip/85977-form-details-empty-block-on-submit into main 2024-01-22 14:05:39 +01:00
Conversation 0 Commits 1 Files Changed 2 +23 -9
fpeters commented 2024-01-22 12:50:35 +01:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-01-22 12:50:36 +01:00
fpeters changed title from WIP: misc: consider hidden blocks as empty in form_details (#85977) to misc: consider hidden blocks as empty in form_details (#85977) 2024-01-22 13:07:07 +01:00
tnoel approved these changes 2024-01-22 14:03:35 +01:00
wcs/fields/block.py
@ -262,3 +262,3 @@
value_info, value_details = super().get_value_info(data)
if value_info is None and value_details not in (None, {'value_id': None}):
if value_info is None and value_details not in (None, {}, {'value_id': None}):
# buggy digest template created an empty value, switch it to an empty string
tnoel commented 2024-01-22 14:03:28 +01:00
Owner
Copy Link

éventuellement compléter "created an empty value" par "created an empty value or a non-displayed page" mais bon c'est tordu.

éventuellement compléter "created an empty value" par "created an empty value or a non-displayed page" mais bon c'est tordu.
fpeters commented 2024-01-22 14:05:35 +01:00
Author
Owner
Copy Link

Comme la modification est annulée dans le ticket qui suit, je ne touche pas au commentaire.

Comme la modification est annulée dans le ticket qui suit, je ne touche pas au commentaire.
fpeters merged commit 49e478cac1 into main 2024-01-22 14:05:39 +01:00
fpeters deleted branch wip/85977-form-details-empty-block-on-submit 2024-01-22 14:05:41 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/wcs#1056
No description provided.
Delete Branch "wip/85977-form-details-empty-block-on-submit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?