entrouvert
/
scrutiny
16
0
Fork 0
Code Issues Pull Requests Releases Activity

add link to ticket in ticket edition popup (#77950) #6

Merged
lguerin merged 1 commits from wip/77950-ticket-link into main 2023-06-01 17:40:39 +02:00
Conversation 0 Commits 1 Files Changed 3 +9 -3
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scrutiny/projects/templates/projects/issue_fragment.html
View File

@ -6,7 +6,7 @@
{% if issue.info.doc_focus %}<span class="icon doc"></span>{% endif %}
</td>
<td class="type">
{{ issue.info.issue_type }}
{{ issue.info.issue_type|default:"" }}
lguerin commented 2023-06-01 15:47:06 +02:00
Outdated
Review
Copy Link

au passage, sinon, si on ne fait qu'afficher la popup et la fermer, ça affiche None au refresh de la page

au passage, sinon, si on ne fait qu'afficher la popup et la fermer, ça affiche None au refresh de la page
</td>
<td class="issue"><a href="{{ issue.url }}">#{{ issue.id }}</a></td>
<td class="subject">

6
scrutiny/projects/templates/projects/issue_info_form.html
View File

@ -1,13 +1,15 @@
{% extends "scrutiny/base.html" %}
{% load gadjo %}
{% block appbar %}
<h2>Infos du ticket #{{ form.instance.issue_id }}</h2>
<h2>Infos du ticket #{{ issue.id }}</h2>
{% endblock %}
{% block content %}
<form method="post" enctype="multipart/form-data">
<p><a href="{{ issue.url }}">{{ issue.url }}</a></p>
tnoel commented 2023-06-01 16:44:32 +02:00
Outdated
Review
Copy Link

Pour montrer que j'ai tout relu je signale qu'il manque un espace entre issue.url et }}.

Pour montrer que j'ai tout relu je signale qu'il manque un espace entre issue.url et }}.
👍 1
lguerin commented 2023-06-01 17:37:39 +02:00
Outdated
Review
Copy Link

et il manquait aussi la ref du ticket dans le message de commit :)

et il manquait aussi la ref du ticket dans le message de commit :)
{% csrf_token %}
{{ form.as_p }}
{{ form|with_template }}
<div class="buttons">
<button class="submit-button">Enregistrer</button>
<a class="cancel" href="/">Annuler</a>

4
scrutiny/projects/views.py
View File

@ -361,6 +361,10 @@ class IssueInfoUpdate(FormView):
self.issue = Issue(kwargs['issue_id'])
return super().dispatch(request, *args, **kwargs)
def get_context_data(self, **kwargs):
kwargs['issue'] = self.issue
return super().get_context_data(**kwargs)
def get_form_kwargs(self):
info, created = IssueInfo.objects.get_or_create(issue_id=self.issue.id)
kwargs = super().get_form_kwargs()