entrouvert
/
publik-base-theme
15
1
Fork 1
Code Issues Pull Requests 9 Releases Wiki Activity

build: replace Pool with ThreadPool to avoid pickle issues (#88335) #549

Merged
tnoel merged 1 commits from wip/88335-setup-use-threadpool-to-avoid-pickle into main 2024-03-19 16:50:14 +01:00
Conversation 0 Commits 1 Files Changed 1 +3 -3
tnoel commented 2024-03-19 15:39:29 +01:00
Owner
Copy Link
No description provided.
tnoel added 1 commit 2024-03-19 15:39:29 +01:00
gitea/publik-base-theme/pipeline/head This commit looks good Details
adfc8d2964 build: replace Pool with ThreadPool to avoid pickle issues (#88335)
pmarillonnet approved these changes 2024-03-19 16:12:24 +01:00
pmarillonnet left a comment
Owner
Copy Link

Ok, je reproduis le fix en local. La doc de multiprocessing n’est pas claire sur la particularité de ThreadPool qui, par rapport à Pool, ne nécessiterait pas la pickabilité des objets passés.

Rien à voir mais la doc recommande à la place l’utilisation de concurrent.futures.ThreadPoolExecutor (https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.ThreadPoolExecutor) à la place, mais pour notre usage spécifique ici on peut dire qu’on s’en fiche :)

Bref, ack.

Ok, je reproduis le fix en local. La doc de multiprocessing n’est pas claire sur la particularité de ThreadPool qui, par rapport à Pool, ne nécessiterait pas la pickabilité des objets passés. Rien à voir mais la doc recommande à la place l’utilisation de `concurrent.futures.ThreadPoolExecutor` (https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.ThreadPoolExecutor) à la place, mais pour notre usage spécifique ici on peut dire qu’on s’en fiche :) Bref, ack.
tnoel merged commit adfc8d2964 into main 2024-03-19 16:50:14 +01:00
tnoel deleted branch wip/88335-setup-use-threadpool-to-avoid-pickle 2024-03-19 16:50:14 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
pmarillonnet
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/publik-base-theme#549
No description provided.
Delete Branch "wip/88335-setup-use-threadpool-to-avoid-pickle"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?