entrouvert
/
publik-base-theme
15
1
Fork 1
Code Issues Pull Requests 9 Releases Wiki Activity

scss: fix readonly checkbox widget position when it should be on the left (#79312) #343

Merged
smihai merged 1 commits from wip/79312-fix-unique-readonly-checkbox-position into main 2023-07-04 14:55:06 +02:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
smihai commented 2023-07-03 13:57:43 +02:00
Owner
Copy Link
No description provided.
smihai commented 2023-07-03 13:58:28 +02:00
Author
Owner
Copy Link

Pour une checkbox readonly le markup côté wcs change: c'est un span au lieu de label. Il faut suivre cote themes.

Pour une checkbox readonly le markup côté wcs change: c'est un `span` au lieu de `label`. Il faut suivre cote themes.
tjund requested changes 2023-07-04 10:26:53 +02:00
static/includes/_forms.scss Outdated
@ -601,3 +601,3 @@
position: static;
}
label {
label, span {
tjund commented 2023-07-04 10:26:50 +02:00
Owner
Copy Link

Autant label, il n'y en a qu'un au sein de .content, autant des spans enfant, tu en as plusieurs d'imbriqués. Je changerais pour > span pour ne cibler que le premier enfant.

Autant `label`, il n'y en a qu'un au sein de .content, autant des spans enfant, tu en as plusieurs d'imbriqués. Je changerais pour `> span` pour ne cibler que le premier enfant.
smihai commented 2023-07-04 10:33:55 +02:00
Author
Owner
Copy Link

Tu as raison. C'est modifié.

Tu as raison. C'est modifié.
smihai marked this conversation as resolved
smihai force-pushed wip/79312-fix-unique-readonly-checkbox-position from 34e01391a1 to 5445e58f5c 2023-07-04 10:33:40 +02:00 Compare
smihai requested review from tjund 2023-07-04 10:34:08 +02:00
tjund approved these changes 2023-07-04 14:53:42 +02:00
smihai merged commit a9a23d59ff into main 2023-07-04 14:55:06 +02:00
smihai deleted branch wip/79312-fix-unique-readonly-checkbox-position 2023-07-04 14:55:06 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tjund
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/publik-base-theme#343
No description provided.
Delete Branch "wip/79312-fix-unique-readonly-checkbox-position"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?