entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 14 Releases Activity

signal_arretes: add support for comment field (#73853) #64

Merged
csechet merged 2 commits from wip/73853-Supporter-le-champ-commentaire-l into main 2023-01-27 14:38:33 +01:00
Conversation 0 Commits 2 Files Changed 3 +10 -1
csechet commented 2023-01-26 13:04:02 +01:00
Owner
Copy Link
No description provided.
Ghost approved these changes 2023-01-27 13:55:48 +01:00
Ghost left a comment
First-time contributor
Copy Link

Un détail de i18n à corriger avant de pousser.

Un détail de i18n à corriger avant de pousser.
passerelle/apps/signal_arretes/models.py Outdated
@ -87,6 +87,7 @@ REQUEST_SCHEMA = {
'format': 'date',
},
'occupation_end_date': {'description': _('Occupation end date'), 'type': 'string', 'format': 'date'},
'comment': {'description': _('Commentaire'), 'type': 'string'},
Ghost commented 2023-01-27 13:54:23 +01:00
First-time contributor
Copy Link

en anglais : ('Comment')

en anglais : ('Comment')
nroche approved these changes 2023-01-27 13:57:31 +01:00
tests/test_signal_arretes.py Outdated
@ -211,6 +212,7 @@ REQUIRED_PARAMETERS = {
'occupation_type': 'Base de vie',
'occupation_start_date': '02/06/2022',
'occupation_end_date': '03/06/2022',
'comment': '',
nroche commented 2023-01-27 13:52:33 +01:00
Owner
Copy Link

J'ai l'impression que tu as oublié d'ajouté ce nouveau champ requis "comment" aux champs 'required' de 'REQUEST_SCHEMA'.

J'ai l'impression que tu as oublié d'ajouté ce nouveau champ requis "comment" aux champs 'required' de 'REQUEST_SCHEMA'.
csechet commented 2023-01-27 14:12:30 +01:00
Author
Owner
Copy Link

Non, le champ n'est pas requis, c'est déroutant mais les champ vides de "REQUIRED_PARAMETERS" ne sont, en fait, pas requis (mauvais nommage de variable, reliquat des discussions ici : https://dev.entrouvert.org/issues/65822#note-10)

Non, le champ n'est pas requis, c'est déroutant mais les champ vides de "REQUIRED_PARAMETERS" ne sont, en fait, pas requis (mauvais nommage de variable, reliquat des discussions ici : https://dev.entrouvert.org/issues/65822#note-10)
csechet force-pushed wip/73853-Supporter-le-champ-commentaire-l from 8c66fe757c to 983dca5d75 2023-01-27 14:19:02 +01:00 Compare
csechet merged commit 671c051c5d into main 2023-01-27 14:38:33 +01:00
csechet deleted branch wip/73853-Supporter-le-champ-commentaire-l 2023-01-27 14:38:33 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Ghost
nroche
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#64
No description provided.
Delete Branch "wip/73853-Supporter-le-champ-commentaire-l"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?