entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 15 Releases Activity

photon: handle "name" and pack other extra properties (#89845) #517

Merged
fpeters merged 1 commits from wip/89845-photon into main 2024-04-26 09:32:47 +02:00
Conversation 0 Commits 1 Files Changed 2 +62 -3
fpeters commented 2024-04-23 12:00:11 +02:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-04-23 12:00:11 +02:00
gitea/passerelle/pipeline/head There was a failure building this commit Details
cf348022b9 photon: handle "name" and pack other extra properties (#89845)
fpeters force-pushed wip/89845-photon from cf348022b9 to 2be2632a92 2024-04-23 12:54:15 +02:00 Compare
fpeters changed title from WIP: photon: handle "name" and pack other extra properties (#89845) to photon: handle "name" and pack other extra properties (#89845) 2024-04-23 13:03:14 +02:00
tnoel approved these changes 2024-04-23 13:42:46 +02:00
tnoel left a comment
Owner
Copy Link

Validé ; avec deux commentaires inutiles.

Validé ; avec deux commentaires inutiles.
passerelle/apps/photon/models.py Outdated
@ -123,2 +134,4 @@
if result['address'].get('house_number'):
result['text'] += '%s, ' % result['address']['house_number']
if result['address'].get('name') and not result['address'].get('road'):
tnoel commented 2024-04-23 13:42:27 +02:00
Owner
Copy Link

On pourrait mettre ça en « elif result['address'].get('name'): » du "if" suivant mais c'est juste que j'ai tatasser.

On pourrait mettre ça en « elif result['address'].get('name'): » du "if" suivant mais c'est juste que j'ai tatasser.
fpeters commented 2024-04-26 09:02:42 +02:00
Author
Owner
Copy Link

J'ai pris cette suggestion.

J'ai pris cette suggestion.
passerelle/apps/photon/models.py Outdated
@ -131,2 +147,4 @@
result['text'] = result['text'].strip()
result['display_name'] = result['text']
if non_standard_properties:
result['extra'] = non_standard_properties
tnoel commented 2024-04-23 13:41:37 +02:00
Owner
Copy Link

On pourrait toujours renvoyer un "extra", même dictionnaire vide, histoire de montrer que ça existe (que ça peut exister).

On pourrait toujours renvoyer un "extra", même dictionnaire vide, histoire de montrer que ça existe (que ça peut exister).
fpeters commented 2024-04-26 09:02:51 +02:00
Author
Owner
Copy Link

Et pas celle-ci :)

Et pas celle-ci :)
fpeters added 1 commit 2024-04-26 08:33:38 +02:00
gitea/passerelle/pipeline/head This commit looks good Details
03f0351327 fixup
fpeters force-pushed wip/89845-photon from 03f0351327 to feb6fd1428 2024-04-26 09:03:03 +02:00 Compare
fpeters merged commit feb6fd1428 into main 2024-04-26 09:32:47 +02:00
fpeters deleted branch wip/89845-photon 2024-04-26 09:32:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#517
No description provided.
Delete Branch "wip/89845-photon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?