entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 16 Releases Activity

misc: allow an "empty" value (single dash) for trace emails (#88841) #504

Merged
fpeters merged 1 commits from wip/88841-no-traces into main 2024-04-26 11:38:16 +02:00
Conversation 0 Commits 1 Files Changed 3 +19 -3
fpeters commented 2024-03-29 09:08:47 +01:00
Owner
Copy Link
No description provided.
fpeters added 1 commit 2024-03-29 09:08:47 +01:00
fpeters force-pushed wip/88841-no-traces from 73e2151a20 to 4c733c8028 2024-03-29 09:10:49 +01:00 Compare
fpeters changed title from WIP: misc: allow an "empty" value (single dash) for trace emails (#88841) to misc: allow an "empty" value (single dash) for trace emails (#88841) 2024-03-29 13:37:31 +01:00
tnoel reviewed 2024-03-29 20:03:33 +01:00
passerelle/base/models.py Outdated
@ -1073,3 +1073,3 @@
admins = settings.ADMINS
logging_parameters = self.connector.logging_parameters
if logging_parameters.trace_emails:
if logging_parameters.trace_emails == '-':
tnoel commented 2024-03-29 20:03:33 +01:00
Owner
Copy Link

On veut laisser ça un peu caché, ou ajouter une petite mention dans le help_text ? Genre

-         help_text=_('One address per line (empty for site administrators)'),
+         help_text=_('One address per line (empty for site administrators, a single dash "-" for no mail at all)'),

En plus c'est mignon "-" ça fait un petit emoji tendance hello kitty ok bon.

On veut laisser ça un peu caché, ou ajouter une petite mention dans le help_text ? Genre ``` - help_text=_('One address per line (empty for site administrators)'), + help_text=_('One address per line (empty for site administrators, a single dash "-" for no mail at all)'), ``` En plus c'est mignon "-" ça fait un petit emoji tendance hello kitty ok bon.
fpeters commented 2024-04-01 09:36:19 +02:00
Author
Owner
Copy Link

J'ai ajouté cette note.

J'ai ajouté cette note.
fpeters force-pushed wip/88841-no-traces from 4c733c8028 to 75fb200762 2024-04-01 08:14:57 +02:00 Compare
nroche approved these changes 2024-04-26 10:09:43 +02:00
fpeters merged commit 09632084c0 into main 2024-04-26 11:38:16 +02:00
fpeters deleted branch wip/88841-no-traces 2024-04-26 11:38:16 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
nroche
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#504
No description provided.
Delete Branch "wip/88841-no-traces"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?