toulouse-maelis: always return err=0 on dlnuf endpoint (#86503) #459

Merged
nroche merged 1 commits from wip/86503-parsifal-no-api-error-on-dlnuf-endpoint into main 2024-02-02 16:58:30 +01:00
2 changed files with 4 additions and 6 deletions

View File

@ -2316,7 +2316,7 @@ class ToulouseMaelis(BaseResource, HTTPResource):
@endpoint(
display_category='Famille',
description='Savoir si un document déjà ajouté est encore valable',
description='Savoir si un document déjà ajouté est encore valable (renvoie "ok" ou "ko")',
name='read-supplied-document-validity',
parameters={
'NameID': {'description': 'Publik NameID'},
@ -2345,9 +2345,7 @@ class ToulouseMaelis(BaseResource, HTTPResource):
'validityDate': ref_date.isoformat() if ref_date else None,
},
)
if response is not True:
raise APIError('document is not valid')
return {'data': 'ok'}
return {'data': 'ok' if response is True else 'ko'}
Outdated
Review

Réponds ok / ko, OK / KO, mais ok/KO tu vas perdre du monde :)

Réponds ok / ko, OK / KO, mais ok/KO tu vas perdre du monde :)
def get_start_and_end_dates(self, start_date, end_date):
try:

View File

@ -4974,8 +4974,8 @@ def test_read_supplied_document_validity(family_service, con, app):
request_check=request_check,
)
resp = app.get(url + '?NameID=local', params=params)
assert resp.json['err'] == 1
assert resp.json['err_desc'] == 'document is not valid'
assert resp.json['err'] == 0
assert resp.json['data'] == 'ko'
def test_read_supplied_document_validity_with_optional_parameters(family_service, con, app):