entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 16 Releases Activity

tests: keep on using deprecated cgi module in tests (#86355) #451

Merged
fpeters merged 2 commits from wip/86355-python-upgrade-pylint into main 2024-01-31 10:58:13 +01:00
Conversation 0 Commits 2 Files Changed 4 +5 -3
4 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
passerelle/apps/csvdatasource/models.py
View File

@ -251,6 +251,8 @@ class CsvDataSource(BaseResource):
file_type = self.csv_file.name.split('.')[-1]
if file_type not in ('ods', 'xls', 'xlsx'):
content = self.get_content_without_bom()
if '\x00' in content:
raise ValueError(_('line contains NUL'))
fpeters commented 2024-01-31 09:53:52 +01:00
Review
Copy Link

Python 3.11 accepte désormais ça mais je préfère qu'on continue à éviter, donc j'ajoute le test explicite.

Python 3.11 accepte désormais ça mais je préfère qu'on continue à éviter, donc j'ajoute le test explicite.
reader = csv.reader(content.splitlines(), **self.dialect_options)
rows = list(reader)

2
tests/test_astre_rest.py
View File

@ -1,5 +1,5 @@
import base64
import cgi
import cgi # noqa pylint: disable=deprecated-module
import io
import json

2
tests/test_toulouse_foederis.py
View File

@ -15,7 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import base64
import cgi
import cgi # noqa pylint: disable=deprecated-module
import json
import os
import urllib.parse

2
tests/test_toulouse_smart.py
View File

@ -15,7 +15,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import base64
import cgi
import cgi # noqa pylint: disable=deprecated-module
import functools
import io
import json