entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 15 Releases Activity

general: log Publik-Caller header (#83111) #390

Merged
ecazenave merged 1 commits from wip/83111-Publik-Caller into main 2023-11-10 11:34:23 +01:00
Conversation 1 Commits 1 Files Changed 2 +18 -15
ecazenave commented 2023-11-03 15:56:54 +01:00
Owner
Copy Link
No description provided.
ecazenave added 1 commit 2023-11-03 15:56:54 +01:00
gitea/passerelle/pipeline/head This commit looks good Details
1ba8db657f general: log Publik-Caller header (#83111)
ecazenave changed title from WIP: general: log Publik-Caller header (#83111) to general: log Publik-Caller header (#83111) 2023-11-03 16:17:07 +01:00
ecazenave reviewed 2023-11-03 16:21:49 +01:00
passerelle/views.py Outdated
@ -477,0 +479,4 @@
'connector': connector_name,
'connector_endpoint': endpoint_name,
'connector_endpoint_url': url,
'publik_caller_url': request.headers.get('Publik-Caller', ''),
ecazenave commented 2023-11-03 16:20:10 +01:00
Author
Owner
Copy Link

Je voulais faire pop plutôt qu'un get en pensant au connecteur proxy sauf c'est un objet immutable.

Mais en fait tout va bien le connecteur proxy ne laisse pas passer n'importe quoi : https://git.entrouvert.org/entrouvert/passerelle/src/branch/main/passerelle/apps/proxy/models.py#L26

Je voulais faire pop plutôt qu'un get en pensant au connecteur proxy sauf c'est un objet immutable. Mais en fait tout va bien le connecteur proxy ne laisse pas passer n'importe quoi : https://git.entrouvert.org/entrouvert/passerelle/src/branch/main/passerelle/apps/proxy/models.py#L26
tnoel commented 2023-11-03 17:13:00 +01:00
Owner
Copy Link

Comme on comprend ici qu'on s'attend à une URL dans Publik-Caller, appelons-le clairement Publik-Caller-URL et le monde sera plus beau.

Comme on comprend ici qu'on s'attend à une URL dans Publik-Caller, appelons-le clairement Publik-Caller-URL et le monde sera plus beau.
ecazenave commented 2023-11-03 16:23:27 +01:00
Author
Owner
Copy Link
No description provided.
Screenshot 2023-11-03 at 15-43-55 Passerelle.png
48 KiB
Screenshot 2023-11-03 at 15-43-55 Passerelle.png
tnoel requested changes 2023-11-03 17:14:55 +01:00
tnoel left a comment
Owner
Copy Link

Juste un petit renommage, tout le reste est bel et bon.

Juste un petit renommage, tout le reste est bel et bon.
ecazenave force-pushed wip/83111-Publik-Caller from 1ba8db657f to 43603d259c 2023-11-03 18:05:31 +01:00 Compare
smihai requested changes 2023-11-06 10:06:22 +01:00
tests/test_generic_endpoint.py Outdated
@ -110,6 +110,7 @@ def test_proxy_logger(mocked_get, caplog, app, arcgis):
'template': '{{ attributes.NOM }}',
'id_template': '{{ attributes.NUMERO }}',
},
headers={'Publik-Caller': 'https://wcs.invalid/backoffice/management/foo/1/'},
smihai commented 2023-11-06 10:06:17 +01:00
Owner
Copy Link

Plutôt Publik-Caller-URL ?

Plutôt `Publik-Caller-URL` ?
ecazenave force-pushed wip/83111-Publik-Caller from 43603d259c to 26e02a0b97 2023-11-07 11:03:28 +01:00 Compare
smihai approved these changes 2023-11-07 14:32:28 +01:00
ecazenave force-pushed wip/83111-Publik-Caller from 26e02a0b97 to 2a73e4dfb3 2023-11-10 11:00:48 +01:00 Compare
ecazenave merged commit 2a73e4dfb3 into main 2023-11-10 11:34:23 +01:00
ecazenave deleted branch wip/83111-Publik-Caller 2023-11-10 11:34:23 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
tnoel
smihai
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#390
No description provided.
Delete Branch "wip/83111-Publik-Caller"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?