entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 15 Releases Activity

toulouse-foederis: don't send filename in Content-Disposition of form-data when posting attachments (#82346) #363

Merged
csechet merged 2 commits from wip/82346-filename-dans-champ-form-data into main 2023-10-16 12:57:26 +02:00
Conversation 1 Commits 2 Files Changed 2 +57 -35
csechet commented 2023-10-13 12:21:59 +02:00
Owner
Copy Link
No description provided.
ecazenave commented 2023-10-13 14:55:57 +02:00
Owner
Copy Link

Je serais surpris que ça marche, tu as moyen de tester avant de pousser ?

En se basant sur la trame de https://dev.entrouvert.org/issues/82204#note-18, je dirais un truc du genre :

data = {'fileName': file['filename'], 'contentType': file['content_type']} files = {'value': (None, file['content'], None)} self.http_request(..., files=files, data=data)

Aussi surpris qu'il faille envoyer le fichier en base64 mais bon si c'est comme ça c'est comme ça, enfin il faudrait pouvoir tester quoi.

Je serais surpris que ça marche, tu as moyen de tester avant de pousser ? En se basant sur la trame de https://dev.entrouvert.org/issues/82204#note-18, je dirais un truc du genre : `data = {'fileName': file['filename'], 'contentType': file['content_type']} files = {'value': (None, file['content'], None)} self.http_request(..., files=files, data=data) ` Aussi surpris qu'il faille envoyer le fichier en base64 mais bon si c'est comme ça c'est comme ça, enfin il faudrait pouvoir tester quoi.
csechet force-pushed wip/82346-filename-dans-champ-form-data from ef292d4573 to 3d5ec0268c 2023-10-16 10:59:28 +02:00 Compare
bdauvergne approved these changes 2023-10-16 12:42:58 +02:00
bdauvergne left a comment
Owner
Copy Link

Ok pour moi, data et files font la même chose mais c'est effectivement plus clair comme cela.

Ok pour moi, data et files font la même chose mais c'est effectivement plus clair comme cela.
👍 1
csechet added 1 commit 2023-10-16 12:47:11 +02:00
gitea/passerelle/pipeline/head This commit looks good Details
76f3860ad2 toulouse-foederis: allow empty degree files (#82390)
csechet merged commit 76f3860ad2 into main 2023-10-16 12:57:26 +02:00
csechet deleted branch wip/82346-filename-dans-champ-form-data 2023-10-16 12:57:26 +02:00
ecazenave approved these changes 2023-10-16 14:01:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
bdauvergne
ecazenave
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#363
No description provided.
Delete Branch "wip/82346-filename-dans-champ-form-data"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?