entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 15 Releases Activity

toulouse-smart: do not crash on receiving string in place of block field (#79816) #325

Merged
nroche merged 1 commits from wip/79816-toulouse-smart-do-not-crash-on-string into main 2023-10-12 15:19:40 +02:00
Conversation 0 Commits 1 Files Changed 2 +20
nroche commented 2023-07-19 14:53:49 +02:00
Owner
Copy Link

Ne pas crasher quand on reçoit une chaîne à la place du bloc de champ attendu.

Ne pas crasher quand on reçoit une chaîne à la place du bloc de champ attendu.
fpeters requested changes 2023-07-19 18:15:28 +02:00
passerelle/contrib/toulouse_smart/models.py Outdated
@ -179,1 +179,4 @@
data = {}
if not isinstance(block, dict):
raise APIError(
"cannot retrieve '%s' block content from post data: get a %s where a dict was excpected"
fpeters commented 2023-07-19 18:15:08 +02:00
Owner
Copy Link

get → got.
excpected → expected.

get → got. excpected → expected.
nroche commented 2023-07-20 10:40:40 +02:00
Author
Owner
Copy Link

J'ai corrigé, merci.

J'ai corrigé, merci.
nroche force-pushed wip/79816-toulouse-smart-do-not-crash-on-string from ddd013fce4 to 52227d15ec 2023-07-20 10:26:06 +02:00 Compare
nroche force-pushed wip/79816-toulouse-smart-do-not-crash-on-string from 52227d15ec to aa58a50257 2023-08-25 14:29:49 +02:00 Compare
nroche force-pushed wip/79816-toulouse-smart-do-not-crash-on-string from aa58a50257 to 194801865e 2023-09-15 18:00:29 +02:00 Compare
nroche force-pushed wip/79816-toulouse-smart-do-not-crash-on-string from 194801865e to f026a54fdc 2023-09-18 10:05:04 +02:00 Compare
nroche force-pushed wip/79816-toulouse-smart-do-not-crash-on-string from f026a54fdc to 79523462f7 2023-09-23 21:39:21 +02:00 Compare
nroche requested review from fpeters 2023-09-23 21:39:52 +02:00
bdauvergne approved these changes 2023-10-03 18:42:03 +02:00
nroche force-pushed wip/79816-toulouse-smart-do-not-crash-on-string from 79523462f7 to f7e20cc493 2023-10-10 10:27:03 +02:00 Compare
nroche force-pushed wip/79816-toulouse-smart-do-not-crash-on-string from f7e20cc493 to f2652bac36 2023-10-12 15:08:58 +02:00 Compare
nroche merged commit f2652bac36 into main 2023-10-12 15:19:40 +02:00
nroche deleted branch wip/79816-toulouse-smart-do-not-crash-on-string 2023-10-12 15:19:40 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
bdauvergne
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/passerelle#325
No description provided.
Delete Branch "wip/79816-toulouse-smart-do-not-crash-on-string"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?