entrouvert
/
passerelle
15
0
Fork 0
Code Issues Pull Requests 15 Releases Activity

grenoble_gru: cleanup phone numbers (#78187) #272

Merged
smihai merged 1 commits from wip/78187-grenoble-gru-cleanup-phones into main 2023-06-12 09:44:25 +02:00
Conversation 0 Commits 1 Files Changed 2 +7
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
passerelle/contrib/grenoble_gru/models.py
View File

@ -107,6 +107,11 @@ class GrenobleGRU(BaseResource):
payload = {'id': data['application_id']}
payload['dem_comp'] = types_params['dem_comp'] = data.get('dem_comp', 'Voirie')
for key, value in data.items():
if key.endswith('_phone'):
phone = ''.join(x for x in value if x in '0123456789')
tnoel commented 2023-06-06 11:31:31 +02:00
Outdated
Review
Copy Link

peut-être plutôt :

phone = ''.join(x for x in value if x in '0123456789')

histoire d'être sur de ne garder que les chiffres en ascii (ça serait plus clair je trouve).

peut-être plutôt : ``` phone = ''.join(x for x in value if x in '0123456789') ``` histoire d'être sur de ne garder que les chiffres en ascii (ça serait plus clair je trouve).
smihai commented 2023-06-06 14:40:55 +02:00
Outdated
Review
Copy Link

Toi, tu ne fais pas confiance au validateur de numéro de wcs.
Remarque prise en compte.

Toi, tu ne fais pas confiance au validateur de numéro de wcs. Remarque prise en compte.
data[key] = phone
payload.update(
{
# applicant informations

2
tests/test_grenoble_gru.py
View File

@ -229,6 +229,7 @@ def test_demand_creation_params(app, setup):
payload = BASIC_PAYLOAD.copy()
payload['intervention_free_address'] = '169, rue du Château'
payload['applicant_free_address'] = '1, rue de l\'Est'
payload['applicant_phone'] = '01-02.03 04 05'
app.post_json(
reverse(
'generic-endpoint',
@ -243,6 +244,7 @@ def test_demand_creation_params(app, setup):
assert request_post.call_args[1]['data']['dem_pav'] == 'déchetterie'
assert request_post.call_args[1]['data']['dem_reponse'] == 0
assert request_post.call_args[1]['data']['obs_description_probleme'] == 'thank you '
assert request_post.call_args[1]['data']['dem_tel'] == '0102030405'
payload['applicant_requires_reply'] = True
payload['urgent_demand'] = 'True'