* nearly all C files: change includes for relative paths.
* lasso/id-wsf/id_wsf.h, lasso/id-wsf-2.0/id_wsf_2.h: add top level
public include files for ID-WSF 1.0 and ID-WSF 2.0.
* lasso/id-ff/server.*, lasso/id-ff/session.*, lasso/id-ff/identity.*:
remove most of the code related to ID-WSF and push into
lasso/id-wsf/id_ff_extensions.* and lasso/id-wsf-2.0/identity.c,
lasso/id-wsf-2.0/server.c, lasso/id-wsf-2.0/session.c.
* lasso/id-wsf-2.0/saml2_login.c,
lasso/id-wsf-2.0/saml2_login_private.h: same change but for ID-WSF
2.0 support in SAML2 SSO profile.
* bindings/overrides.xml:
some functions have output parameters (pointer on pointers) that are
currently not supported by our binding generator, so we skip them.
* tests/data/response-3:
this dump of a SAML message contains elements and attribute outside
the SAML schema, implementation detail from Lasso. They broke
execution of tests/tests2.
* extract_symbols.py, extract_types.py:
export SOAP types whatever the value of the flag --enable-wsf.
It still worked because constructor for GObject calls get_type, but
there is a race condition: if you receive a SOAP message before
sending one, it fails. Only soap_binding types must be removed.
* id-ff/session.h: seal public fields.
* id-ff/session.c, id-ff/sessionprivate.h: add accessors for reading
the is_dirty flag and counting store assertions.
* id-ff/logout.c, id-ff/login.c, saml-2.0/login.c, saml-2.0/logout.c,
saml-2.0/profile.c: use the new accessors.
* id-ff/profile.c: include the private header file, use the new
accessors, and remove unnecessary setting of is_dirty to FALSE (it
should be false at instanciation).
* utils.h: add a macro to access private content, prepare for using
G_TYPE_INSTANCE_GET_PRIVATE and the GObject infrastructure for
private structures eventually.
Migrate lots of code to use new utility macros. Try to simplify most
code paths or to factorize with LassoWsfProfile.
* lasso/id-wsf/wsf_profile.c:
Add API:
- lasso_wsf_profile_build_soap_response_msg to build SOAP fault for
Lasso errors,
- lasso_wsf_profile_set_msg_url_from_description, to set the
destination URL using the chosen LassoDiscoDescription (with
respect to the security mechanism),
- lasso_wsf_profile_init_soap_response to initialize a response to
the current request, to use in sub classes,
- lasso_wsf_profile_get_remote_provider_id, retrieve the SOAP
binding corresponding information,
- lasso_wsf_profile_get_remote_provider, simplification of
lasso_wsf_profile_get_remote_provider_id,
- lasso_wsf_profile_get_soap_fault, retrieve the last setted SOAP
fault, used by sub classes,
- lasso_wsf_profile_set_soap_fault, set a SOAP fault, to be returned
by the next call by lasso_wsf_profile_build_soap_response_msg, to
use in sub classes,
- lasso_wsf_profile_set/get_status_code, set/get the stored status
code, to use in the next lasso_xxx_build_response_message, to use
in sub classes.
Change name lasso_wsf_profile_get_description_autos to
lasso_wsf_profile_get_description_auto.
Do not access directly the session is_dirty field (it has been
sealed).
* lasso/id-wsf/wsf_profile.h:
Add helper macro lasso_wsf_profile_helper_set_status to set status
code of an ID-WSF response message containing a Status element using
the stored status code.
* lasso/id-wsf/wsf_profile_private.h:
Add new fields (moved public fields).
Add lasso_wsf_profile_set_msg_url_from_description,
lasso_wsf_profile_build_soap_fault_response_msg.
* lasso/id-wsf/data_service_private.h:
Remove file.
* lasso/id-wsf/data_service.h: Remove all public fields.
* lasso/id-wsf/data_service.c:
Remove private structure. Use the equivalents LassoWsfProfile private
fields. Update documentation. Use LassoWsfProfile generic functions
for initializing requests. Add API lasso_data_service_get_query_item,
lasso_data_service_get_answers, lasso_data_service_get_answer,
lasso_data_service_get_answers_by_select,
lasso_data_service_get_answer_for_item_id,
lasso_data_service_add_modification.
Remove lasso_data_service_need_redirect_user use equivalent function
lasso_interaction_profile_service_build_redirect_response_msg. Remove
lasso_data_service_get_resource_offering,
lasso_data_service_set_offering.
* lasso/id-wsf/discovery.c:
Add documentation. Change some signatures. Remove
lasso_discovery_get_description_auto. Change name of
lasso_discovery_init_insert to lasso_discovery_init_modify. Add a
generic lasso_discovery_process_request_msg.
Add internal function lasso_discovery_init_offering, to get
automatically an offering if possible. Remove useless init_from_xml.
Rework lasso_discovery_build_credential implementation.
overloading. Remove lasso_discovery_destroy.
* lasso/id-wsf/discovery.h:
Remove lasso_discovery_destroy.
* lasso/id-wsf/interaction_profile_service.c:
Add lasso_interaction_profile_service_build_redirect_response_msg.
* lasso/id-wsf/personal_profile_service.c:
Update lasso_personal_profile_service_get_email to use
lasso_data_service_get_answers_by_select.
* lasso/xml/dst_modify.c:
make modification parameter optional to the constructor.
* xml/saml-2.0/saml2_attribute_value.h:
add new public field GHashTable *attributes;
* xml/saml-2.0/saml2_attribute_value.c:
add parsing instructions to populate attributes field.
* lasso/id-wsf/wsf_profile.c
(lasso_wsf_profile_comply_with_saml_authentication):
reuse existing wsse-security element if present,
remove useless comments, move core code after argument type checks,
return error if enveloppe or header is missing,
fail if any referenced assertion is missing,
correctly handle reference count of wsse_security depending on
the situation (new or reused).
* lasso/id-wsf/discovery.c (lasso_discovery_add_insert_entry):
the rule is that callee is responsible for becoming owner of a resource,
so no g_object_ref before a call on an argument.
* lasso/id-wsf-2.0/profile.c, lasso/id-wsf-2.0/profile.h
(lasso_idwsf2_profile_build_soap_envelope):
as for ID-WSF 1.0 export this function to allow easier implementation
of external ID-WSF 2.0 services. remove FIXME comment and fill
equivalent bugzilla reports.
* lasso/id-wsf-2.0/discovery.c
(lasso_idwsf2_discovery_process_metadata_register_response_msg):
change return code variable to rc, move argument casting after argument
type check, copy all the service metadata ids,
* lasso/id-wsf-2.0/discovery.c
(lasso_idwsf2_discovery_init_metadata_register):
add documentation comment, move argument casting after type checking,
change return code name to rc to comply with standardisation,
use lasso_build_unique_id instead of duplicating the code,
add iteration over all the registered service, add iteration
to return all the generated service metadata ids, use new assignment
macros.
* lasso/id-wsf-2.0/discovery.h (struct _LassoIdWsf2Discovery):
change field LassoIdWsf2DiscoSvcMetadata metadata to GList* metadatas
and gchar *svcMDID to GList *svcMDIDs in order to support multiple
services in requests.
* lasso/id-wsf-2.0/discovery.c (lasso_idwsf2_discovery_register_self)
move casting after argument type check, simplify code by using
lasso_build_unique_id, remove useless comments
- lasso/xml/id-wsf-2.0/utils_status.h (lasso_idwsf2_util_status_new_with_code):
this constructor allow to construct and fill a UtilStatus node with
one line. It has two arguments to construct nested two level
status objects (with two status codes). If you omit the second
argument you get a one level status object.
- lasso/id-wsf-2.0/data_service.c:
- lasso_idwsf2_data_service_parse_query_items: use the new API to
remove error outputs from libxml, and generate an additional status
code containing newly returned libxml error code.
- lasso_idwsf2_data_service_parse_one_modify_item: use the new API.
* lasso/xml/tools.c,lasso/xml/private.h:
- lasso_eval_xpath_expression(xmlXPathContextPtr xpathCtx,
const char *expression, xmlXPathObjectPtr *xpathObjectPtr,
int *xpathErrorCode) is a boolean returning function handling call
to libxml API to evaluate en XPath expression in the xpathCtx
context. It eventually save the returned nodeset in the variable
pointed by xpathObjectPtr if it is not-NULL
(and eventually deallocate previous value)
and if an error happend it copy its code into the variable
pointed to by xpathErrorCode if it is not NULL.
* bindings/pyhton/wrapper_top.c (set_hashtable_of_pygobject):
second argument (int*ppos) of PyDict_Next must be reinitialized to
zero before each traversal (see Python C API
http://docs.python.org/c-api/dict.html).
Patch from Iban Rodríguez of the Desarrollo de Producto Electrónico,
Spain.
* lasso/saml-2.0/profile.c:
HTTP Redirect binding mandate to remove signature at the SAML message
level, but signatures at the assertion, especially if the SP asked for
it, must be preserved.
* lasso/id-wsf-2.0/data_service.c:
the specification for data service template indicat that the query
must fail at the first failing query, we think this is a stupid
behaviour so I set the default to keep running query until the last
one and returning a partial result if at least one failed and a
failed result if absolutely no query matched.
* lasso/id-wsf-2.0/private.h:
declare the lasso_flag_follow_id_wsf_supid_semantic flag.
* lasso.c:
declare the lasso_flag_follow_id_wsf_supid_semantic flag, it's
conditionned by the LASSO_WSF_ENABLED preprocessor symbol.
* tests/integration/saml2/__init__.py:
if /usr/bin/valgrind exist, use script valgrind-wrapper.sh to launch
tests, it stores log files in {authentic,lcs}_$ISODATE_pid$PID.log.
* id-ff/login.c:
* id-ff/logout.c:
* id-ff/profile.c:
* id-ff/provider.c:
* id-ff/server.c:
fix leaks by using field setting macros which frees previous values,
it also reduce code length sometimes.
Benjamin Dauvergne