entrouvert
/
hobo
16
0
Fork 0
Code Issues Pull Requests 16 Releases Activity

Prévention de la désactivation d’un attribut de profil utilisé comme identifiant dans Authentic (#79137) #64

Merged
pmarillonnet merged 2 commits from wip/79137-warning-on-phone-identifier-deactivation into main 2023-08-02 12:58:15 +02:00
Conversation 0 Commits 2 Files Changed 3 +151 -1
pmarillonnet commented 2023-08-02 11:40:55 +02:00
Owner
Copy Link
No description provided.
pmarillonnet added 2 commits 2023-08-02 11:40:55 +02:00
pmarillonnet force-pushed wip/79137-warning-on-phone-identifier-deactivation from f6e6fe5220 to 5b6dd57d94 2023-08-02 11:46:09 +02:00 Compare
pmarillonnet force-pushed wip/79137-warning-on-phone-identifier-deactivation from 5b6dd57d94 to c93c518d95 2023-08-02 12:19:27 +02:00 Compare
pmarillonnet changed title from WIP: Prévention de la désactivation d’un attribut de profil utilisé comme identifiant dans Authentic (#79137) to Prévention de la désactivation d’un attribut de profil utilisé comme identifiant dans Authentic (#79137) 2023-08-02 12:19:33 +02:00
fpeters reviewed 2023-08-02 12:36:47 +02:00
hobo/profile/utils.py Outdated
@ -22,0 +31,4 @@
def get_authn_information_from_idp():
if cached := cache.get('authn-information'):
fpeters commented 2023-08-02 12:35:23 +02:00
Owner
Copy Link

On pourrait déplacer la gestion du cache vers le RequestsWrapper mais ok.

On pourrait déplacer la gestion du cache vers le RequestsWrapper mais ok.
pmarillonnet commented 2023-08-03 12:41:47 +02:00
Author
Owner
Copy Link

Ok, dans un autre ticket alors : #80246

Ok, dans un autre ticket alors : #80246
hobo/profile/utils.py Outdated
@ -22,0 +41,4 @@
return {}
else:
url = urllib.parse.urljoin(url, 'api/authn-healthcheck/')
response = requests.get(url)
fpeters commented 2023-08-02 12:36:44 +02:00
Owner
Copy Link

je mettrais timeout=5 et le nécessaire d'attrapage d'exception autour, qu'une erreur ici ne bloque jamais.

je mettrais timeout=5 et le nécessaire d'attrapage d'exception autour, qu'une erreur ici ne bloque jamais.
pmarillonnet commented 2023-08-02 12:51:50 +02:00
Author
Owner
Copy Link

C’est corrigé, merci.

C’est corrigé, merci.
pmarillonnet force-pushed wip/79137-warning-on-phone-identifier-deactivation from c93c518d95 to fe13ea1151 2023-08-02 12:47:18 +02:00 Compare
pmarillonnet force-pushed wip/79137-warning-on-phone-identifier-deactivation from fe13ea1151 to 478bb172a0 2023-08-02 12:48:27 +02:00 Compare
fpeters approved these changes 2023-08-02 12:52:46 +02:00
pmarillonnet merged commit 1cc7e24506 into main 2023-08-02 12:58:15 +02:00
pmarillonnet deleted branch wip/79137-warning-on-phone-identifier-deactivation 2023-08-02 12:58:15 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/hobo#64
No description provided.
Delete Branch "wip/79137-warning-on-phone-identifier-deactivation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?