entrouvert
/
hobo
16
0
Fork 0
Code Issues Pull Requests 18 Releases Activity

application: check icon from bundle before install (#88251) #118

Merged
lguerin merged 1 commits from wip/88251-application-image-check into main 2024-04-26 10:56:42 +02:00
Conversation 0 Commits 1 Files Changed 4 +54 -20
lguerin commented 2024-03-18 17:54:18 +01:00
Owner
Copy Link
No description provided.
lguerin added 1 commit 2024-03-18 17:54:18 +01:00
gitea/hobo/pipeline/head There was a failure building this commit Details
22e8bc8be3
application: check icon from bundle before install (#88251)
lguerin force-pushed wip/88251-application-image-check from 22e8bc8be3 to ad01d3d634 2024-03-19 11:17:57 +01:00 Compare
fpeters reviewed 2024-04-26 09:39:10 +02:00
tests/test_application.py Outdated
@ -945,3 +939,1 @@
tarinfo = tarfile.TarInfo('foo.png')
tarinfo.size = len(icon_fd.getvalue())
tar.addfile(tarinfo, fileobj=icon_fd)
with open(os.path.join(TESTS_DATA_DIR, 'black.jpeg'), mode='rb') as icon_fd:
fpeters commented 2024-04-26 09:39:10 +02:00
Owner
Copy Link

Ça ne me semble pas critique mais j'ajouterais *.jpeg au MANIFEST.in (recursive-include tests *.py *.json).

Ça ne me semble pas critique mais j'ajouterais *.jpeg au MANIFEST.in (`recursive-include tests *.py *.json`).
lguerin commented 2024-04-26 10:48:39 +02:00
Author
Owner
Copy Link

ok, fait

ok, fait
fpeters approved these changes 2024-04-26 09:39:17 +02:00
lguerin force-pushed wip/88251-application-image-check from ad01d3d634 to e4ed6bc825 2024-04-26 10:48:30 +02:00 Compare
lguerin force-pushed wip/88251-application-image-check from e4ed6bc825 to adc499222b 2024-04-26 10:54:49 +02:00 Compare
lguerin merged commit adc499222b into main 2024-04-26 10:56:42 +02:00
lguerin deleted branch wip/88251-application-image-check 2024-04-26 10:56:42 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/hobo#118
No description provided.
Delete Branch "wip/88251-application-image-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?