entrouvert
/
gitea-eo-custom
16
0
Fork 0
Code Issues Pull Requests Releases Activity

reviews: only consider latest user reviews (#77536) #6

Merged
fpeters merged 1 commits from wip/77536-reviews-latest-only into main 2023-05-17 16:31:32 +02:00
Conversation 0 Commits 1 Files Changed 1 +5
fpeters commented 2023-05-12 13:43:47 +02:00
Owner
Copy Link

Nouvelle lecture du code de gitea, il n'y a en fait pas de flag sur les relectures pour dire qu'elles sont passées (il y a un flag "stale", il ne sert pas, ou pas à ça), ça passe par "prendre la dernière", cf models/issues/review.go,

        // Get latest review of each reviewer, sorted in order they were made
        if err := sess.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = 0 AND type in (?, ?, ?) AND dismissed = ? AND original_author_id = 0 GROUP BY issue_id, reviewer_id) ORDER BY review.updated_unix ASC",
                issueID, ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest, false).

Bref je fais pareil (sauf la partie "reviewer team" qu'on n'utilise pas).

Nouvelle lecture du code de gitea, il n'y a en fait pas de flag sur les relectures pour dire qu'elles sont passées (il y a un flag "stale", il ne sert pas, ou pas à ça), ça passe par "prendre la dernière", cf models/issues/review.go, ``` // Get latest review of each reviewer, sorted in order they were made if err := sess.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = 0 AND type in (?, ?, ?) AND dismissed = ? AND original_author_id = 0 GROUP BY issue_id, reviewer_id) ORDER BY review.updated_unix ASC", issueID, ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest, false). ``` Bref je fais pareil (sauf la partie "reviewer team" qu'on n'utilise pas).
fpeters added 1 commit 2023-05-12 13:43:47 +02:00
gitea/gitea-eo-custom/pipeline/head This commit looks good Details
f98231d1c6 reviews: only consider latest user reviews (#77536)
aberriot approved these changes 2023-05-17 10:12:17 +02:00
fpeters merged commit f98231d1c6 into main 2023-05-17 16:31:32 +02:00
fpeters deleted branch wip/77536-reviews-latest-only 2023-05-17 16:31:32 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
aberriot
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/gitea-eo-custom#6
No description provided.
Delete Branch "wip/77536-reviews-latest-only"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?