entrouvert
/
gadjo
15
0
Fork 0
Code Issues Pull Requests 2 Releases Activity

tabSelect: skip selection from fragment if error is displayed (#81867) #37

Open
pmarillonnet wants to merge 1 commits from wip/81867-tabSelect-on-no-errornotice-only into main
pull from: wip/81867-tabSelect-on-no-errornotice-only
merge into: entrouvert:main
Conversation 0 Commits 1 Files Changed 1 +7 -2
pmarillonnet commented 2023-10-02 15:05:03 +02:00
Owner
Copy Link
No description provided.
pmarillonnet added 1 commit 2023-10-02 15:05:04 +02:00
pmarillonnet changed title from tabSelect: skip selection from fragment if error is displayed (#81867) to WIP: tabSelect: skip selection from fragment if error is displayed (#81867) 2023-10-02 15:13:07 +02:00
pmarillonnet force-pushed wip/81867-tabSelect-on-no-errornotice-only from e6784f0f04 to 45cc155560 2023-10-02 15:17:39 +02:00 Compare
pmarillonnet changed title from WIP: tabSelect: skip selection from fragment if error is displayed (#81867) to tabSelect: skip selection from fragment if error is displayed (#81867) 2023-10-02 15:18:21 +02:00
fpeters requested changes 2023-10-05 21:59:31 +02:00
gadjo/static/js/gadjo.js Outdated
@ -363,1 +362,3 @@
if (document.location.hash && document.location.hash.indexOf('#open:') == 0) {
/* if no error to be displayed, focus tab from #open:<tab slug> anchor, to point to open panel */
/* when an error is to be displayed, let the template decide which tab is selected; do nothing here */
if (!document.getElementsByClassName('errornotice').length && document.location.hash && document.location.hash.indexOf('#open:') == 0) {
fpeters commented 2023-10-05 21:59:27 +02:00
Owner
Copy Link

C'est peut-être un peu large de chercher dans tout le document, dans le cas de combo on peut avoir plusieurs zones avec des onglets, on ne voudrait pas empêcher l'une d'aller sur le bon onglet parce qu'une autre affiche une erreur; je serais pour limiter le sélecteur au contenu de la zone d'onglet concernée par le hash.

C'est peut-être un peu large de chercher dans tout le document, dans le cas de combo on peut avoir plusieurs zones avec des onglets, on ne voudrait pas empêcher l'une d'aller sur le bon onglet parce qu'une autre affiche une erreur; je serais pour limiter le sélecteur au contenu de la zone d'onglet concernée par le hash.
pmarillonnet commented 2023-10-10 17:48:03 +02:00
Author
Owner
Copy Link

Ok, fair enough, je vais faire la modif.

Ok, fair enough, je vais faire la modif.
bdauvergne marked this conversation as resolved
pmarillonnet changed title from tabSelect: skip selection from fragment if error is displayed (#81867) to WIP: tabSelect: skip selection from fragment if error is displayed (#81867) 2023-10-10 17:48:07 +02:00
pmarillonnet force-pushed wip/81867-tabSelect-on-no-errornotice-only from 45cc155560 to fb69e7be05 2023-10-19 11:57:39 +02:00 Compare
pmarillonnet requested review from fpeters 2023-10-19 11:57:53 +02:00
pmarillonnet changed title from WIP: tabSelect: skip selection from fragment if error is displayed (#81867) to tabSelect: skip selection from fragment if error is displayed (#81867) 2023-10-19 11:57:59 +02:00
bdauvergne requested changes 2023-12-20 12:14:01 +01:00
gadjo/static/js/gadjo.js
@ -364,0 +362,4 @@
/* if no error to be displayed, focus tab from #open:<tab slug> anchor, to point to open panel */
/* when an error is to be displayed, let the template decide which tab is selected; do nothing here */
if (
!document.querySelector('.pk-tabs--container').getElementsByClassName('errornotice').length
bdauvergne commented 2023-12-20 12:13:58 +01:00
Owner
Copy Link

Ça ne correspond pas à la demande de Fred je pense. Pour faire ce que demande Fred il faut d'abord rechercher l'onglet correspondant au hash, puis au final vérifier si le conteneur parent contient une erreur ou pas et si il ne contient pas d'erreur, alors sélectionner l'onglet ciblé.

Ça ne correspond pas à la demande de Fred je pense. Pour faire ce que demande Fred il faut d'abord rechercher l'onglet correspondant au hash, puis au final vérifier si le conteneur parent contient une erreur ou pas et si il ne contient pas d'erreur, alors sélectionner l'onglet ciblé.
All checks were successful
gitea/gadjo/pipeline/head This commit looks good
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b wip/81867-tabSelect-on-no-errornotice-only main
git pull origin wip/81867-tabSelect-on-no-errornotice-only

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff wip/81867-tabSelect-on-no-errornotice-only
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
bdauvergne
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/gadjo#37
No description provided.
Delete Branch "wip/81867-tabSelect-on-no-errornotice-only"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?