entrouvert
/
combo
16
1
Fork 0
Code Issues Pull Requests 11 Releases Wiki Activity

map: add int conversion before comparing zoom levels (#86631) #230

Merged
yweber merged 1 commits from wip/86631-bugfix-map-zoom-comparison into main 2024-02-07 11:20:34 +01:00
Conversation 0 Commits 1 Files Changed 2 +10 -3
yweber commented 2024-02-07 10:39:50 +01:00
Owner
Copy Link
No description provided.
yweber added 1 commit 2024-02-07 10:39:51 +01:00
yweber changed title from WIP: map: add int conversion before comparing zoom levels (#86631) to map: add int conversion before comparing zoom levels (#86631) 2024-02-07 10:45:55 +01:00
vdeniaud approved these changes 2024-02-07 11:08:53 +01:00
combo/apps/maps/forms.py Outdated
@ -135,3 +135,1 @@
initial_zoom = cleaned_data.get('initial_zoom')
max_zoom = cleaned_data.get('max_zoom')
min_zoom = cleaned_data.get('min_zoom')
initial_zoom = int(cleaned_data.get('initial_zoom'))
vdeniaud commented 2024-02-07 11:06:01 +01:00
Owner
Copy Link

Ici on pourrait en profiter pour réécrire en cleaned_data['initial_zoom'], ça fait un peu tiquer d'appeler int() sur un truc qui peut valoir None (ce n'est jamais le cas donc autant ne pas le laisser croire)

Ici on pourrait en profiter pour réécrire en `cleaned_data['initial_zoom']`, ça fait un peu tiquer d'appeler `int()` sur un truc qui peut valoir None (ce n'est jamais le cas donc autant ne pas le laisser croire)
yweber marked this conversation as resolved
yweber force-pushed wip/86631-bugfix-map-zoom-comparison from 65eb70ce26 to ec57e7c060 2024-02-07 11:17:22 +01:00 Compare
yweber merged commit ec57e7c060 into main 2024-02-07 11:20:34 +01:00
yweber deleted branch wip/86631-bugfix-map-zoom-comparison 2024-02-07 11:20:34 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
vdeniaud
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/combo#230
No description provided.
Delete Branch "wip/86631-bugfix-map-zoom-comparison"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?