entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 8 Releases Wiki Activity

historisation des changements (#86634) #213

Merged
lguerin merged 7 commits from wip/86634-snapshots into main 2024-02-27 16:20:52 +01:00
Conversation 0 Commits 7 Files Changed 25 +1273 -218
lguerin commented 2024-02-16 15:12:40 +01:00
Owner
Copy Link
No description provided.
lguerin added 3 commits 2024-02-16 15:12:41 +01:00
lguerin force-pushed wip/86634-snapshots from 8f9f14f31e to 72f904d0a7 2024-02-16 15:13:44 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from 72f904d0a7 to 5002385aed 2024-02-22 09:40:53 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from 5002385aed to 97fac92c51 2024-02-22 10:09:34 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from 97fac92c51 to cc1e84787d 2024-02-22 16:21:25 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from cc1e84787d to f44c2ead6a 2024-02-22 17:28:36 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from f44c2ead6a to 53cba981f1 2024-02-22 17:35:13 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from 53cba981f1 to fa24c556f8 2024-02-23 15:25:44 +01:00 Compare
lguerin changed title from WIP: historisation des changements (#86634) to historisation des changements (#86634) 2024-02-23 15:26:20 +01:00
lguerin force-pushed wip/86634-snapshots from fa24c556f8 to 86ec40fe49 2024-02-23 15:30:15 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from 86ec40fe49 to 3615cc7ede 2024-02-27 11:50:43 +01:00 Compare
fpeters reviewed 2024-02-27 14:32:23 +01:00
chrono/manager/views.py Outdated
@ -1205,12 +1243,18 @@ class AgendaEditView(ManagedAgendaMixin, UpdateView):
title = _('Edit Agenda')
model = Agenda
form_class = AgendaEditForm
comment = None
fpeters commented 2024-02-27 14:26:28 +01:00
Owner
Copy Link

J'aurais suggéré un nom plus précis, type snapshot_comment, mais j'ai regardé dans combo et j'y avais mis "comment" pareil donc je me tais.

J'aurais suggéré un nom plus précis, type snapshot_comment, mais j'ai regardé dans combo et j'y avais mis "comment" pareil donc je me tais.
chrono/manager/views.py Outdated
@ -2471,1 +2522,4 @@
def form_valid(self, *args, **kwargs):
response = super().form_valid(*args, **kwargs)
self.agenda.take_snapshot(request=self.request, comment=_('added event %s') % self.object)
fpeters commented 2024-02-27 14:29:21 +01:00
Owner
Copy Link

Ici et sur les autres, dans les messages, je serais pour mettre le %s entre parenthèses (ou guillemets?), ça me semble meilleur pour la lisibilité des chaines traduites ensuite. ex : évènement ajouté (blah); guichet supprimé (blah), etc.

Ici et sur les autres, dans les messages, je serais pour mettre le %s entre parenthèses (ou guillemets?), ça me semble meilleur pour la lisibilité des chaines traduites ensuite. ex : évènement ajouté (blah); guichet supprimé (blah), etc.
lguerin commented 2024-02-27 15:28:56 +01:00
Author
Owner
Copy Link

mis entre parenthèses

mis entre parenthèses
chrono/manager/views.py Outdated
@ -3178,1 +3256,3 @@
return super().form_valid(form)
response = super().form_valid(form)
self.agenda.take_snapshot(
request=self.request, comment=_('added ressource %s') % form.cleaned_data['resource']
fpeters commented 2024-02-27 14:27:31 +01:00
Owner
Copy Link

Dans le message i lfaudrait resource avec un seul s.

Dans le message i lfaudrait resource avec un seul s.
lguerin commented 2024-02-27 15:28:44 +01:00
Author
Owner
Copy Link

corrigé

corrigé
chrono/manager/views.py Outdated
@ -3193,6 +3275,7 @@ class AgendaResourceDeleteView(ManagedAgendaMixin, DeleteView):
def delete(self, request, *args, **kwargs):
self.object = self.get_object()
self.agenda.resources.remove(self.object)
self.agenda.take_snapshot(request=request, comment=_('removed ressource %s') % self.object)
fpeters commented 2024-02-27 14:27:39 +01:00
Owner
Copy Link

Pareil resource avec un seul s.

Pareil resource avec un seul s.
lguerin commented 2024-02-27 15:28:39 +01:00
Author
Owner
Copy Link

corrigé

corrigé
lguerin force-pushed wip/86634-snapshots from 3615cc7ede to 76c54dfb52 2024-02-27 15:28:31 +01:00 Compare
lguerin force-pushed wip/86634-snapshots from 76c54dfb52 to 176d23aa4b 2024-02-27 15:33:19 +01:00 Compare
fpeters approved these changes 2024-02-27 15:48:41 +01:00
lguerin merged commit 176d23aa4b into main 2024-02-27 16:20:52 +01:00
lguerin deleted branch wip/86634-snapshots 2024-02-27 16:20:52 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#213
No description provided.
Delete Branch "wip/86634-snapshots"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?