entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 4 Releases Wiki Activity

agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974) #208

Merged
yweber merged 2 commits from wip/85974-avoid-cascade-when-deleting-eventtype into main 2024-01-23 14:17:37 +01:00
Conversation 1 Commits 2 Files Changed 4 +101 -1
yweber commented 2024-01-22 12:18:22 +01:00
Owner
Copy Link
No description provided.
yweber added 1 commit 2024-01-22 12:18:23 +01:00
gitea/chrono/pipeline/head There was a failure building this commit Details
172f38d90a agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974)
yweber force-pushed wip/85974-avoid-cascade-when-deleting-eventtype from 172f38d90a to c7eefafb75 2024-01-22 12:23:23 +01:00 Compare
yweber changed title from WIP: agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974) to agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974) 2024-01-22 12:25:55 +01:00
yweber force-pushed wip/85974-avoid-cascade-when-deleting-eventtype from c7eefafb75 to 7c1ab68497 2024-01-22 12:26:08 +01:00 Compare
yweber changed title from agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974) to WIP: agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974) 2024-01-22 12:26:42 +01:00
yweber force-pushed wip/85974-avoid-cascade-when-deleting-eventtype from 7c1ab68497 to 08a58078ad 2024-01-22 15:13:03 +01:00 Compare
yweber changed title from WIP: agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974) to agendas: change on_delete for Agenda -> EventsType to SET_NULL (#85974) 2024-01-22 15:16:28 +01:00
lguerin reviewed 2024-01-22 19:01:31 +01:00
tests/manager/test_events_type.py Outdated
@ -164,1 +164,4 @@
def test_delete_referenced_events_type(app):
events_type = EventsType.objects.create(label='Foobar')
events_type.save()
lguerin commented 2024-01-22 19:00:52 +01:00
Owner
Copy Link

pas besoin de save ici, rien n'a été modifié depuis le create

pas besoin de save ici, rien n'a été modifié depuis le create
yweber marked this conversation as resolved
tests/manager/test_events_type.py Outdated
@ -165,0 +166,4 @@
events_type = EventsType.objects.create(label='Foobar')
events_type.save()
agenda = Agenda(label='Foo Bar', events_type=events_type)
lguerin commented 2024-01-22 19:01:19 +01:00
Owner
Copy Link

Agenda.objects.create pour économiser un save :)

Agenda.objects.create pour économiser un save :)
yweber commented 2024-01-23 09:23:35 +01:00
Author
Owner
Copy Link

Super, merci :)

Super, merci :)
yweber marked this conversation as resolved
yweber force-pushed wip/85974-avoid-cascade-when-deleting-eventtype from 08a58078ad to 3b3d558444 2024-01-23 09:22:08 +01:00 Compare
lguerin approved these changes 2024-01-23 13:14:22 +01:00
lguerin left a comment
Owner
Copy Link

ok pour moi, mais attention pas de merge cette semaine :)

ok pour moi, mais attention pas de merge cette semaine :)
fpeters commented 2024-01-23 13:40:47 +01:00
Owner
Copy Link

ok pour moi, mais attention pas de merge cette semaine :)

Vu sur jabber, on pourrait en fait merger, pour éviter deux semaines de plus avec ce risque de perte de données en production.

> ok pour moi, mais attention pas de merge cette semaine :) Vu sur jabber, on pourrait en fait merger, pour éviter deux semaines de plus avec ce risque de perte de données en production.
yweber force-pushed wip/85974-avoid-cascade-when-deleting-eventtype from 3b3d558444 to 9945568a57 2024-01-23 14:14:48 +01:00 Compare
yweber merged commit 9945568a57 into main 2024-01-23 14:17:37 +01:00
yweber deleted branch wip/85974-avoid-cascade-when-deleting-eventtype 2024-01-23 14:17:38 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#208
No description provided.
Delete Branch "wip/85974-avoid-cascade-when-deleting-eventtype"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?