entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 4 Releases Wiki Activity

api: add places_reserved field in booking API response (#84523) #203

Merged
yweber merged 1 commits from wip/84523-api-booking-places-reserved into main 2024-01-17 10:03:18 +01:00
Conversation 0 Commits 1 Files Changed 2 +28
yweber commented 2024-01-17 09:23:27 +01:00
Owner
Copy Link
No description provided.
yweber added 1 commit 2024-01-17 09:23:27 +01:00
yweber changed title from WIP: api: add places_reserved field in booking API response (#84523) to api: add places_reserved field in booking API response (#84523) 2024-01-17 09:28:55 +01:00
vdeniaud approved these changes 2024-01-17 09:48:16 +01:00
vdeniaud left a comment
Owner
Copy Link

Mini remarque à appliquer, à part ça c'est tout bon !

Mini remarque à appliquer, à part ça c'est tout bon !
chrono/api/views.py Outdated
@ -2807,6 +2807,7 @@ class BookingAPI(APIView):
{
'err': 0,
'booking_id': self.booking.pk,
'places_reserved': self.booking.secondary_booking_set.count() + 1,
vdeniaud commented 2024-01-17 09:43:52 +01:00
Owner
Copy Link

J'aimerais mieux que la clé s'appelle places_count, ça me paraît plus cohérent avec le ?count passé lors de la réservation

J'aimerais mieux que la clé s'appelle `places_count`, ça me paraît plus cohérent avec le ?count passé lors de la réservation
yweber marked this conversation as resolved
bdauvergne approved these changes 2024-01-17 09:48:39 +01:00
yweber force-pushed wip/84523-api-booking-places-reserved from d968e1310f to f2285f7880 2024-01-17 09:56:28 +01:00 Compare
yweber merged commit f2285f7880 into main 2024-01-17 10:03:18 +01:00
yweber deleted branch wip/84523-api-booking-places-reserved 2024-01-17 10:03:18 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
vdeniaud
bdauvergne
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#203
No description provided.
Delete Branch "wip/84523-api-booking-places-reserved"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?