entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 4 Releases Wiki Activity

agendas: store computed times for partial bookings (#80877) #150

Merged
lguerin merged 2 commits from wip/80877-partial-bookings-store-computed-times into main 2023-10-02 17:10:16 +02:00
Conversation 0 Commits 2 Files Changed 10 +410 -11
lguerin commented 2023-09-19 15:13:02 +02:00
Owner
Copy Link
No description provided.
lguerin force-pushed wip/80877-partial-bookings-store-computed-times from 2270fffe43 to 27982491a1 2023-09-19 15:20:31 +02:00 Compare
lguerin changed title from WIP: agendas: store computed times for partial bookings (#80877) to agendas: store computed times for partial bookings (#80877) 2023-09-19 15:29:39 +02:00
lguerin force-pushed wip/80877-partial-bookings-store-computed-times from 27982491a1 to 1e867bbbcb 2023-09-21 21:24:45 +02:00 Compare
lguerin added 1 commit 2023-09-21 21:54:32 +02:00
gitea/chrono/pipeline/head There was a failure building this commit Details
3fcfb97645
misc: fix test for partial bookings running after 18h (#80877)
lguerin force-pushed wip/80877-partial-bookings-store-computed-times from 3fcfb97645 to de21d898eb 2023-09-23 09:00:11 +02:00 Compare
vdeniaud reviewed 2023-09-26 14:58:40 +02:00
chrono/agendas/models.py Outdated
@ -2967,0 +3040,4 @@
old_computed_start_time == self.computed_start_time
and old_computed_end_time == self.computed_end_time
):
return
vdeniaud commented 2023-09-26 12:30:08 +02:00
Owner
Copy Link

Une optimisation qui ferait gagner davantage de requêtes que celle-ci ce serait d'appeler Booking.objects.bulk_update dans les méthodes async_, aucune idée du gain réel cependant

Une optimisation qui ferait gagner davantage de requêtes que celle-ci ce serait d'appeler Booking.objects.bulk_update dans les méthodes async_, aucune idée du gain réel cependant
lguerin commented 2023-10-02 15:48:46 +02:00
Author
Owner
Copy Link

j'ai modifié le code pour faire avec bulk_update

j'ai modifié le code pour faire avec bulk_update
tests/api/test_event.py Outdated
@ -1404,6 +1404,7 @@ def test_events_check_status_events(app, user, partial_bookings):
user_check_start_time=datetime.time(7, 55),
user_check_end_time=datetime.time(17, 15),
)
booking1.refresh_computed_times()
vdeniaud commented 2023-09-26 14:54:21 +02:00
Owner
Copy Link

Cette ligne est vraiment utile sachant qu'on passe par la méthode get_computed_start_time en dessous ?

Cette ligne est vraiment utile sachant qu'on passe par la méthode get_computed_start_time en dessous ?
lguerin commented 2023-10-02 15:49:17 +02:00
Author
Owner
Copy Link

j'ai enlevé les appels à get_computed_foo, et plutôt ajouté un test sur les champs computed_foo

j'ai enlevé les appels à get_computed_foo, et plutôt ajouté un test sur les champs computed_foo
lguerin force-pushed wip/80877-partial-bookings-store-computed-times from de21d898eb to db1c185b1f 2023-10-02 15:33:50 +02:00 Compare
lguerin force-pushed wip/80877-partial-bookings-store-computed-times from db1c185b1f to 15b2b26c08 2023-10-02 15:48:21 +02:00 Compare
vdeniaud approved these changes 2023-10-02 17:04:43 +02:00
lguerin merged commit 15b2b26c08 into main 2023-10-02 17:10:16 +02:00
lguerin deleted branch wip/80877-partial-bookings-store-computed-times 2023-10-02 17:10:16 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
vdeniaud
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#150
No description provided.
Delete Branch "wip/80877-partial-bookings-store-computed-times"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?