entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 5 Releases Wiki Activity

api: remove legacy fillslots views (#80352) #128

Merged
vdeniaud merged 1 commits from wip/80352-Supprimer-les-anciennes-api-de-r into main 2023-08-16 13:11:09 +02:00
Conversation 1 Commits 1 Files Changed 7 +108 -828
vdeniaud commented 2023-08-09 16:53:33 +02:00
Owner
Copy Link
No description provided.
vdeniaud force-pushed wip/80352-Supprimer-les-anciennes-api-de-r from e19462a6c5 to d965ed53f2 2023-08-09 17:08:50 +02:00 Compare
vdeniaud force-pushed wip/80352-Supprimer-les-anciennes-api-de-r from d965ed53f2 to 7b2763ef19 2023-08-09 17:18:18 +02:00 Compare
vdeniaud force-pushed wip/80352-Supprimer-les-anciennes-api-de-r from 7b2763ef19 to 9959e4d3d5 2023-08-09 17:21:39 +02:00 Compare
vdeniaud changed title from WIP: api: remove legacy fillslots views (#80352) to api: remove legacy fillslots views (#80352) 2023-08-09 17:24:17 +02:00
lguerin reviewed 2023-08-10 10:09:33 +02:00
lguerin left a comment
Owner
Copy Link

c'est beau tout ce code supprimé :)

c'est beau tout ce code supprimé :)
chrono/api/views.py Outdated
@ -1443,3 +1390,1 @@
datetimes.add(make_aware(datetime.datetime.strptime(datetime_str, '%Y-%m-%d-%H%M')))
except ValueError:
raise APIErrorBadRequest(N_('bad datetime format: %s'), datetime_str)
meeting_type_id = timeslot_id.split(':')[0]
lguerin commented 2023-08-10 09:59:21 +02:00
Owner
Copy Link

tu dois pouvoir simplifier encore un peu ici, c'était je crois pour vérifier que tous les slots avaient le même meeting_type_id ?

tu dois pouvoir simplifier encore un peu ici, c'était je crois pour vérifier que tous les slots avaient le même meeting_type_id ?
chrono/api/views.py Outdated
@ -1503,3 +1460,2 @@
available_desk_rate = 0
for dt in datetimes:
available_desk_rate += fill_rates[available_desk.agenda][dt.date()]['fill_rate']
available_desk_rate += fill_rates[available_desk.agenda][slot_datetime.date()][
lguerin commented 2023-08-10 10:00:54 +02:00
Owner
Copy Link

pas besoin du +=, available_desk_rate est init juste au-dessus

pas besoin du +=, available_desk_rate est init juste au-dessus
chrono/api/views.py Outdated
@ -1509,2 +1465,2 @@
for dt in datetimes:
desk_rate += fill_rates[desk.agenda][dt.date()]['fill_rate']
desk_rate = 0
desk_rate += fill_rates[desk.agenda][slot_datetime.date()]['fill_rate']
lguerin commented 2023-08-10 10:01:26 +02:00
Owner
Copy Link

ici aussi, pas besoin du +=

ici aussi, pas besoin du +=
chrono/api/views.py Outdated
@ -1571,2 +1504,2 @@
if primary_booking is None:
primary_booking = new_booking
# book event
if agenda.accept_meetings():
lguerin commented 2023-08-10 10:05:39 +02:00
Owner
Copy Link

relicat du code avant split, je pense qu'on peut virer cette condition, on est forcément sur une agenda de type meetings/virtual

relicat du code avant split, je pense qu'on peut virer cette condition, on est forcément sur une agenda de type meetings/virtual
vdeniaud force-pushed wip/80352-Supprimer-les-anciennes-api-de-r from 9959e4d3d5 to 84463c84bf 2023-08-16 11:13:42 +02:00 Compare
vdeniaud commented 2023-08-16 11:25:38 +02:00
Author
Owner
Copy Link

Remarques appliquées, merci pour la vigilance !

Remarques appliquées, merci pour la vigilance !
vdeniaud requested review from lguerin 2023-08-16 11:25:48 +02:00
lguerin approved these changes 2023-08-16 12:30:50 +02:00
vdeniaud merged commit 84463c84bf into main 2023-08-16 13:11:09 +02:00
vdeniaud deleted branch wip/80352-Supprimer-les-anciennes-api-de-r 2023-08-16 13:11:09 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lguerin
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#128
No description provided.
Delete Branch "wip/80352-Supprimer-les-anciennes-api-de-r"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?