entrouvert
/
chrono
14
1
Fork 0
Code Issues Pull Requests 5 Releases Wiki Activity

pre-commit, forcer l'utilisation de single quote (#79866) #120

Merged
vdeniaud merged 3 commits from wip/79866-pre-commit-forcer-l-utilisation- into main 2023-08-02 14:00:33 +02:00
Conversation 0 Commits 3 Files Changed 18 +82 -76
vdeniaud commented 2023-07-20 16:26:25 +02:00
Owner
Copy Link

On voit que ça ne touche pas aux chaînes qui contiennent un apostrophe, https://git.entrouvert.org/entrouvert/chrono/src/branch/wip/79866-pre-commit-forcer-l-utilisation-/chrono/agendas/models.py#L1923

        assert self.agenda.kind != 'virtual', "a meetingtype can't reference a virtual agenda"
On voit que ça ne touche pas aux chaînes qui contiennent un apostrophe, https://git.entrouvert.org/entrouvert/chrono/src/branch/wip/79866-pre-commit-forcer-l-utilisation-/chrono/agendas/models.py#L1923 ``` assert self.agenda.kind != 'virtual', "a meetingtype can't reference a virtual agenda" ```
vdeniaud changed title from WIP: pre-commit, forcer l'utilisation de single quote (#79866) to pre-commit, forcer l'utilisation de single quote (#79866) 2023-07-20 16:58:14 +02:00
fpeters approved these changes 2023-08-02 11:52:42 +02:00
fpeters left a comment
Owner
Copy Link

mini commentaires et ok ensuite sans attendre.

mini commentaires et ok ensuite sans attendre.
.git-blame-ignore-revs Outdated
@ -22,2 +22,4 @@
# misc: bump djhtml version (#75442)
34309253eddc15f17a280656a3ffec072e79731a
# misc: apply double-quote-string-fixer (#79866)
bd6d17a974971bb3397d68a9451a93329543b339
fpeters commented 2023-08-02 11:51:46 +02:00
Owner
Copy Link

Ça sera vraisemblablement à ajuster.

Ça sera vraisemblablement à ajuster.
.pre-commit-config.yaml Outdated
@ -4,0 +4,4 @@
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
hooks:
- id: double-quote-string-fixer
fpeters commented 2023-08-02 11:52:17 +02:00
Owner
Copy Link

Il y a une indentation tout à fait légale yaml mais qui ne correspond pas au reste du fichier, c'est un peu moche.

Il y a une indentation tout à fait légale yaml mais qui ne correspond pas au reste du fichier, c'est un peu moche.
vdeniaud force-pushed wip/79866-pre-commit-forcer-l-utilisation- from a8f0c476a6 to b0f8af1dea 2023-08-02 12:18:28 +02:00 Compare
vdeniaud merged commit b0f8af1dea into main 2023-08-02 14:00:33 +02:00
vdeniaud deleted branch wip/79866-pre-commit-forcer-l-utilisation- 2023-08-02 14:00:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
fpeters
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/chrono#120
No description provided.
Delete Branch "wip/79866-pre-commit-forcer-l-utilisation-"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?