facture: factorize CPFFilter (#89413) #35

Open
bdauvergne wants to merge 1 commits from wip/89413-Factorisation-filtre-par-CPF into main
Owner
No description provided.
bdauvergne added 1 commit 2024-04-11 09:46:49 +02:00
gitea/barbacompta/pipeline/head This commit looks good Details
35b83841b7
facture: factorize CPFFilter (#89413)
bdauvergne force-pushed wip/89413-Factorisation-filtre-par-CPF from 35b83841b7 to 64196c3354 2024-04-11 09:52:02 +02:00 Compare
bdauvergne added 1 commit 2024-04-11 10:11:34 +02:00
gitea/barbacompta/pipeline/head There was a failure building this commit Details
dde45bcc14
facture: show filter by cpf only if necessary (#89413)
bdauvergne force-pushed wip/89413-Factorisation-filtre-par-CPF from dde45bcc14 to 0510fb2ae7 2024-04-11 10:19:28 +02:00 Compare
bdauvergne force-pushed wip/89413-Factorisation-filtre-par-CPF from 0510fb2ae7 to 45dbbfa2d3 2024-04-11 11:46:39 +02:00 Compare
bdauvergne force-pushed wip/89413-Factorisation-filtre-par-CPF from 45dbbfa2d3 to 7384549e1a 2024-04-11 11:55:01 +02:00 Compare
bdauvergne changed title from WIP: facture: factorize CPFFilter (#89413) to facture: factorize CPFFilter (#89413) 2024-04-11 11:58:56 +02:00
nroche approved these changes 2024-04-19 17:46:18 +02:00
nroche left a comment
Owner

Ack
(j'ai pas vraiment testé l'existant côté CPF).

Ack (j'ai pas vraiment testé l'existant côté CPF).
@ -195,2 +199,4 @@
raw_id_fields = ['chorus_structure']
def get_list_filter(self, request):
list_filter = super().get_list_filter(request)
Owner

Pourquoi pas juste list_filter = self.list_filter?

Pourquoi pas juste `list_filter = self.list_filter`?
All checks were successful
gitea/barbacompta/pipeline/head This commit looks good
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b wip/89413-Factorisation-filtre-par-CPF main
git pull origin wip/89413-Factorisation-filtre-par-CPF

Step 2:

Merge the changes and update on Gitea.
git checkout main
git merge --no-ff wip/89413-Factorisation-filtre-par-CPF
git push origin main
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: entrouvert/barbacompta#35
No description provided.