a11y: remove autofocus of username input field (#78108) #77

Merged
fpeters merged 1 commits from wip/78108-remove-autofocus into main 2023-06-23 08:07:20 +02:00
3 changed files with 1 additions and 5 deletions

View File

@ -36,7 +36,6 @@ from ..utils import misc as utils_misc
class AuthenticationForm(auth_forms.AuthenticationForm):
username = auth_forms.UsernameField(
widget=forms.TextInput(attrs={'autofocus': True}),
required=True,
)
password = PasswordField(label=_('Password'))

View File

@ -748,9 +748,6 @@ def login_password_login(request, authenticator, *args, **kwargs):
if request.user.is_authenticated and request.login_token.get('action'):
form.initial['username'] = request.user.username or request.user.email
form.fields['username'].widget.attrs['readonly'] = True
form.fields['password'].widget.attrs['autofocus'] = True
else:
form.fields['username'].widget.attrs['autofocus'] = not (bool(context.get('block_index')))
if app_settings.A2_ACCEPT_EMAIL_AUTHENTICATION:
form.fields['username'].label = _('Username or email')
if app_settings.A2_ACCEPT_PHONE_AUTHENTICATION:

View File

@ -101,7 +101,7 @@ def test_login_username_autofocus(settings, app, franceconnect):
models.FcAuthenticator.objects.update(order=3)
response = app.get('/login/')
assert response.text.index('div id="fc-button"') > response.text.index('name="login-password-submit"')
assert response.pyquery('#id_username').attr.autofocus is not None
assert response.pyquery('#id_username').attr.autofocus is None
def test_create(settings, app, franceconnect, hooks, service, mailoutbox):